Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use edm4hep::Const* types for compatibility with newer podio #184

Closed
vvolkl opened this issue Sep 21, 2021 · 6 comments
Closed

Use edm4hep::Const* types for compatibility with newer podio #184

vvolkl opened this issue Sep 21, 2021 · 6 comments

Comments

@vvolkl
Copy link
Contributor

vvolkl commented Sep 21, 2021

Currently, cepcsw cannot be built in the nightlies because AIDASoft/podio#193 means that edm4hep interfaces now should use the Const* types.

Unfortunately, the typenames will change again soon (AIDASoft/podio#205), so maybe you prefer to wait until after that one is merged with fixing this issue, but it will be necessary in order to make a new release of the full key4hep software.

The current nightly builds don't include cepcsw until this issue is fixed, but should have all the dependencies and can be used for testing:

source /cvmfs/sw-nightlies.hsf.org/key4hep/setup.sh
@mirguest
Copy link
Member

Hi @vvolkl ,
Thank you for letting us know about the changes. We would prefer to wait a bit.
Tao

@mirguest
Copy link
Member

Hi @vvolkl ,
I update the edm4hep interfaces in CEPCSW in #185 . The "auto" is used to avoid the explict typename.
Could you build CEPCSW with the nightlies again? Is that possible to enable the Garfield++ in the nightlies?
Thank you again.
Tao

@vvolkl
Copy link
Contributor Author

vvolkl commented Sep 28, 2021

Hi Tao Lin, ok! we're still debugging a test failure with the wrapper, I'll let you know when I have added Garfield.

@mirguest
Copy link
Member

Hi Tao Lin, ok! we're still debugging a test failure with the wrapper, I'll let you know when I have added Garfield.

Thanks Valentin.

@vvolkl
Copy link
Contributor Author

vvolkl commented Oct 7, 2021

Hi @mirguest,

I've added Garfield to the nightlies, but there is still a build failure in cepsw --I think we can merge AIDASoft/podio#224 soon after which it should be easier to use the newest podio.
Cheers,
Valentin

@mirguest
Copy link
Member

mirguest commented Oct 9, 2021

@vvolkl Thanks again. I know the reason. Because Genfit is not built in the nightlies version, so the cmake skip this module. That's why I don't find the problem.
Tao

@vvolkl vvolkl closed this as completed Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants