Make clone return a mutable object #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mac workflows seem to have cvmfs problems at the moment. |
vvolkl
reviewed
Oct 7, 2021
|
@vvolkl - can you follow up with the Mac build issues and machine states? |
|
I think the mac build issues could be related to github changing |
Seems I wasn't reading carefully. thought that ran on one of our machines... |
|
Playing in #225 with macOS versions. |
Co-authored-by: Valentin Volkl <valentin.volkl@cern.ch>
tmadlener
force-pushed
the
mutable-clone
branch
from
4ec3b9e
to
eb2d10e
Compare
|
rebased to pick up the fixed macos workflows. |
|
OK. seems fine now, except cvfms hiccups. Will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
clonefunction always return a mutable object, also when called on an immutable object (Fixes Discussion: should "clone" of a constant object return a new mutable object? #219)ENDRELEASENOTES
Following the discussion in #219 maybe we could also add a
mutableCopyfor the immutable objects that simply callsclone?