nvme_gw: implicitly create transports #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trociny
force-pushed
the
wip-transport-config
branch
from
ce03e44
to
139b1f2
Compare
trociny
force-pushed
the
wip-transport-config
branch
from
139b1f2
to
e26ad66
Compare
PepperJo
suggested changes
May 23, 2022
Signed-off-by: Mykola Golub <mykola.golub@clyso.com>
trociny
force-pushed
the
wip-transport-config
branch
from
e26ad66
to
d1465b2
Compare
idryomov
reviewed
May 24, 2022
trociny
force-pushed
the
wip-transport-config
branch
2 times, most recently
from
60f48ed
to
d9ec721
Compare
idryomov
reviewed
May 25, 2022
Instead of providing create_transport command, implicitly create
transports that are specified in spdk/transports config option
(space separated values).
Also support transport_{name}_options config param in spdk section
to specify transport specific options (json encoded string).
Fixes: ceph#12
Signed-off-by: Mykola Golub <mykola.golub@clyso.com>
trociny
force-pushed
the
wip-transport-config
branch
from
d9ec721
to
8fb7d4c
Compare
|
@idryomov Thanks. Updated. |
|
Looks good! @PepperJo I think we are on the same page now, but I'd rather not override your "Changes requested". Please ack and I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of providing create_transport command, implicitly create
transports that are specified in spdk/transports config option
(space separated values).
Additionally one may use spdk/transport_{name}_options to
specify transport specific options (space separated key=val)
Fixes: #12
Signed-off-by: Mykola Golub mykola.golub@clyso.com