Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win32_deps_build.sh: change Boost URL #55081

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

petrutlucian94
Copy link
Contributor

@petrutlucian94 petrutlucian94 commented Jan 8, 2024

The Boost download URL is broken again [1], we'll switch to a working mirror.

Fixes: https://tracker.ceph.com/issues/63952

[1] boostorg/boost#842

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@petrutlucian94 petrutlucian94 added the win32 Specifix changes for the windows platform label Jan 8, 2024
win32_deps_build.sh Outdated Show resolved Hide resolved
The Boost download URL is broken again [1], we'll switch to a
working mirror.

[1] boostorg/boost#842

Fixes: https://tracker.ceph.com/issues/63952

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
@idryomov idryomov merged commit adb1aee into ceph:main Jan 8, 2024
10 of 11 checks passed
@cbodley
Copy link
Contributor

cbodley commented Jan 8, 2024

thanks @petrutlucian94. if the windows build can't use https://download.ceph.com/qa/boost_1_82_0.tar.bz2 because of the .bz2, we might upload the .gz there as well to save on some lab bandwidth

@petrutlucian94
Copy link
Contributor Author

thanks @petrutlucian94. if the windows build can't use https://download.ceph.com/qa/boost_1_82_0.tar.bz2 because of the .bz2, we might upload the .gz there as well to save on some lab bandwidth

Makes sense, here's a PR that switches to the ceph hosted source: #55100. bz2 should be ok, I've added bzip2 to the list of requirements to make sure that it's available, especially with containerized builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/ops win32 Specifix changes for the windows platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants