Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more flexible polymorphic types lookup #1424

Closed
wants to merge 3 commits into from
Closed

fix: more flexible polymorphic types lookup #1424

wants to merge 3 commits into from

Commits on Jan 18, 2024

  1. refactor: lookup polymorphic types only once

    @bf4
    bf4 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    a9484d9 View commit details
    Browse the repository at this point in the history

  2. fix: more flexible polymorphic types lookup

    @bf4
    bf4 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    6deebf3 View commit details
    Browse the repository at this point in the history

  3. test: add polymorphic lookup tests 

    they pass on v-11-dev

I'm going to look into the existing lookup warnings

now
```
[POLYMORPHIC TYPE NOT FOUND] No polymorphic types found for fileable
[POLYMORPHIC TYPE] No polymorphic types found for FilePropertiesResource fileable
[POLYMORPHIC TYPE NOT FOUND] No polymorphic types found for respondent
[POLYMORPHIC TYPE] No polymorphic types found for QuestionResource respondent
[POLYMORPHIC TYPE NOT FOUND] No polymorphic types found for respondent
[POLYMORPHIC TYPE] No polymorphic types found for AnswerResource respondent
[POLYMORPHIC TYPE NOT FOUND] No polymorphic types found for keepable
[POLYMORPHIC TYPE] No polymorphic types found for KeeperResource keepable
```
    @bf4
    bf4 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    cc46f11 View commit details
    Browse the repository at this point in the history