Clean up storage model #31

certainty · 2021-09-17T04:27:51Z

No description provided.

We're dealing with references now in set!

This implements the scheme storage model more closely. All special constructs like set-local, set-global and set-upvalue have been replaced by get-local, get-global, get-upvalue followed by a set!. All of those now return a setable reference which is simply updated.

src/compiler/frontend/expander/define.rs

src/compiler/frontend/parser/assignment.rs

src/vm/instance.rs

certainty · 2021-09-17T15:14:52Z

src/vm/instance.rs

-    fn read_identifier(&mut self, addr: ConstAddressType) -> Result<Symbol> {
-        if let Value::Symbol(s) = self.read_constant(addr) {
+    fn read_identifier(&mut self, address: ConstAddressType) -> Result<Symbol> {
+        if let Value::Symbol(s) = self.read_constant(address) {
            Ok(s.clone())


This clone shouldn’t be needed

certainty added 14 commits September 12, 2021 13:11

Add vm test that points out the problem

800d21e

WIP

283f562

WIP

858d66f

Replace RefValue with Reference<Value>

769324f

Meaningful failing test

9706187

We're dealing with references now in set!

Lists are treated correctly

e108881

Replace set-global with just set!

2c428a2

Expand storage model to vector

66f1b2b

Merge branch 'main' into clean-up-storage-model

fb4ea1d

model value access explicitly

166aa7c

Model access pattern explicitly

8392fd8

Some cleanup

3fa39c8

Fix append implementation

f7a7988