Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make samplesheet parser tolerable to underscores in enum names #1006

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

Donaim
Copy link
Member

@Donaim Donaim commented Aug 28, 2023

Solves #888

@Donaim Donaim marked this pull request as ready for review August 28, 2023 23:04
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0121ba5) 86.43% compared to head (459ec49) 86.43%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           samplesheetparser    #1006   +/-   ##
==================================================
  Coverage              86.43%   86.43%           
==================================================
  Files                     28       28           
  Lines                   6110     6110           
==================================================
  Hits                    5281     5281           
  Misses                   829      829           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@donkirkby donkirkby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did I give you the new sample sheet that Hope created? We should confirm that this code will parse it.

micall/tests/test_sample_sheet_parser.py Outdated Show resolved Hide resolved
Co-authored-by: Don Kirkby <donkirkby@users.noreply.github.com>
@Donaim
Copy link
Member Author

Donaim commented Sep 11, 2023

Did I give you the new sample sheet that Hope created?

No, I did not get one from you yet

We should confirm that this code will parse it.

For sure 👍

@Donaim
Copy link
Member Author

Donaim commented Sep 12, 2023

@donkirkby This fix is independent from changes required by the new format that we got from Hope. In other words, it does not fix the issues with the new format, but that is because they are not related to the current issue (#888) that it does fix.

@Donaim Donaim merged commit 3da5255 into samplesheetparser Sep 13, 2023
3 checks passed
@Donaim Donaim deleted the samplesheetparser-fix branch May 13, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants