Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test data issue on ACF 11 / MySQL #304

Closed
perdjurner opened this issue Jul 24, 2014 · 5 comments
Closed

Fix test data issue on ACF 11 / MySQL #304

perdjurner opened this issue Jul 24, 2014 · 5 comments
Assignees
Milestone

Comments

@perdjurner
Copy link
Contributor

Run the test suite on ACF 11 and make sure all tests pass.

@perdjurner perdjurner added this to the 1.3.0 milestone Jul 24, 2014
@scahyono
Copy link
Contributor

On windows, ACF11, MySQL 5.6.19, only two database specific failure

Package Tests Failures Errors
model.properties.defaults 4 2 0
Package Test Name Time Status
defaults database defaults load after create 65 Failure
assert failed: StructKeyExists(loc.user, "birthTime") and TimeFormat(loc.user.birthTime, "HH:mm:ss") eq "18:26:08"
"18:26:08" = '18:26:08'
StructKeyExists = coldfusion.runtime.CFPageMethod@188aacf0
defaults database defaults load after save 14 Failure
assert failed: StructKeyExists(loc.user, "birthTime") and TimeFormat(loc.user.birthTime, "HH:mm:ss") eq "18:26:08"
"18:26:08" = '18:26:08'
StructKeyExists = coldfusion.runtime.CFPageMethod@2477ac7b
defaults new model with property defaults 58 Success
defaults new model with property defaults set to blank 2 Success

@perdjurner
Copy link
Contributor Author

Hard to read this part here:

StructKeyExists(loc.user, "birthTime") and TimeFormat(loc.user.birthTime, "HH:mm:ss") eq "18:26:08"
"18:26:08" = '18:26:08'

Is it an issue with single quotes versus double quotes or what's going on with that failure?

@perdjurner
Copy link
Contributor Author

Maybe we need to do something special with loc.dateTimeDefault inside populate.cfm when it's a MySQL database?

@scahyono
Copy link
Contributor

Looks like false positive, either data or test problem. The cfwheels code
seems to be okay.
On Jul 25, 2014 12:01 AM, "Per Djurner" notifications@github.com wrote:

Maybe we need to do something special with loc.dateTimeDefault inside
populate.cfm when it's a MySQL database?


Reply to this email directly or view it on GitHub
#304 (comment).

@perdjurner
Copy link
Contributor Author

I agree, I think we're good to go for 1.3 then.
Setting this to 1.3.1 so we can fix the issue with the test data.

@perdjurner perdjurner modified the milestones: 1.3.1, 1.3.0 Jul 24, 2014
@perdjurner perdjurner changed the title Test on ACF 11 Fix test data issue on ACF 11 / MySQL Jul 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants