Skip to content

Commit

Permalink
chore(node): clean up root scripts (rolldown#520)
Browse files Browse the repository at this point in the history
<!-- Thank you for contributing! -->

### Description

<!-- Please insert your description here and provide especially info about the "what" this PR is solving -->

### Test Plan

<!-- e.g. is there anything you'd like reviewers to focus on? -->

---
  • Loading branch information
hyf0 committed Mar 10, 2024
1 parent 10b1d0a commit 129772d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ jobs:
run: yarn install

- name: Oxc Lint
run: yarn lint
run: yarn lint-code

- name: Lint Filename
run: yarn lint-filename
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ jobs:
run: yarn install

- name: Build Node Packages
run: yarn build:node:ci
run: yarn workspace @rolldown/node run build

- name: Upload Node Artifact
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion justfile
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ lint-rust:

lint-node:
yarn lint-filename
yarn lint
yarn lint-code
yarn prettier:ci

lint:
Expand Down
16 changes: 6 additions & 10 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"scripts"
],
"scripts": {
"lint": "oxlint --ignore-path=./.oxlintignore --import-plugin --deny-warnings",
"lint-code": "oxlint --ignore-path=./.oxlintignore --import-plugin --deny-warnings",
"lint-filename": "ls-lint",
"watch": "yarn run build --watch",
"build": "DEBUG='rolldown:*' node ./scripts/build-node-binding.js",
Expand All @@ -32,15 +32,11 @@
"format:ci": "run-s prettier:ci toml:ci",
"type-check": "yarn workspaces foreach --all --parallel run type-check",
"bench": "yarn workspace bench run bench",
"build:ts": "tsc -b tsconfig.project.json",
"docs": "cd web/docs && yarn dev",
"docs:build": "cd web/docs && yarn build",
"docs:preview": "cd web/docs && yarn preview",
"docs": "yarn workspace rolldown-docs run dev",
"docs:build": "yarn workspace rolldown-docs run build",
"docs:preview": "yarn workspace rolldown-docs run preview",
"version": "yarn lerna version --force-publish --no-private --no-git-tag-version && node scripts/post-version.cjs",
"changelog": "conventional-changelog -p angular -i CHANGELOG.md -s",
"TODO(hyf0): #need to investigate following commands": "_",
"build:ci:release": "run-s build:node:ci build:binding:release",
"build:node:ci": "yarn workspace @rolldown/node run build"
"changelog": "conventional-changelog -p angular -i CHANGELOG.md -s"
},
"license": "MIT",
"devDependencies": {
Expand All @@ -66,4 +62,4 @@
"engines": {
"node": ">=18.18.0"
}
}
}

0 comments on commit 129772d

Please sign in to comment.