Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement iterable assertion #1592

Merged
merged 4 commits into from
Feb 11, 2024
Merged

Implement iterable assertion #1592

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0e6dd7
Implement `iterator` assertion
koddsson Jan 28, 2024
6b8c0cd
Consider `string` to be iterable
koddsson Jan 28, 2024
0e2db37
Revert changes to `isSubsetOf`
koddsson Jan 29, 2024
f19bceb
Move iterable check out of `an()` function
koddsson Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert changes to isSubsetOf
  • Loading branch information
@koddsson
koddsson committed Jan 29, 2024
commit 0e2db37241ad5367859be7a906ae39a4cc8a466b
4 changes: 1 addition & 3 deletions lib/chai/core/assertions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3043,9 +3043,7 @@ Assertion.addMethod('closeTo', closeTo);
Assertion.addMethod('approximately', closeTo);

// Note: Duplicates are ignored if testing for inclusion instead of sameness.
function isSubsetOf(_subset, _superset, cmp, contains, ordered) {
let superset = Array.from(_superset);
let subset = Array.from(_subset);
function isSubsetOf(subset, superset, cmp, contains, ordered) {
if (!contains) {
if (subset.length !== superset.length) return false;
superset = superset.slice();
Expand Down