renaming image-copy-gcr to image-copy-gcp #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Drake <mark@chainguard.dev>
imjasonh
approved these changes
May 25, 2024
Just double checked - nope! I'm working on the companion doc for this example now and we haven't mentioned on academy yet otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it made sense to update this example (which is useful and works perfectly fine) to reflect recent changes to GCP's product offerings. They recently deprecated GCR and the service will be totally shut down in 2025.
This PR updates the name of this example to
image-copy-gcpand updates other docs in this repository to reflect the change.After updating it ✨ works on my machine ✨ but I may very well have missed something important, so please test things out yourself.