Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hover-card): add manual open and close functions to the connect api #472

Merged

Conversation

TimKolberger
Copy link
Contributor

📝 Description

Add open and close functions to the hover card connect api:

⛳️ Current behavior (updates)

Missing way to control the machine.

🚀 New behavior

import * as hoverCard from "@zag-js/hover-card"
const api = hoverCard.connect(state, send, normalizeProps)
// call `open` to open the hover card
api.open()
// call `close` to close the hover card
api.close()

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Prerequisite to OSS-518

@linear
Copy link

linear bot commented Jan 14, 2023

OSS-624 feat(hover-card): add open and close functions

Prerequisite of OSS-518

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2023

🦋 Changeset detected

Latest commit: a2e9d42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@zag-js/hover-card Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
zag-nextjs ✅ Ready (Inspect) Visit Preview Jan 14, 2023 at 10:47PM (UTC)
zag-solid ✅ Ready (Inspect) Visit Preview Jan 14, 2023 at 10:47PM (UTC)
zag-vue ✅ Ready (Inspect) Visit Preview Jan 14, 2023 at 10:47PM (UTC)

@github-actions
Copy link
Contributor

Visualize the logic of the machines here 🎊

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a2e9d42:

Sandbox Source
next-ts Configuration

@segunadebayo segunadebayo merged commit ccd562f into main Jan 15, 2023
@segunadebayo segunadebayo deleted the feature/oss-624-feathover-card-add-open-and-close branch January 15, 2023 16:27
@github-actions github-actions bot mentioned this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants