Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle notifications when merging MRs #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Moussto
Copy link

@Moussto Moussto commented Oct 24, 2019

Hey !

I figured I'd add two snackbar notifications (success and error) when trying to merge Mrs, there's no real error handling per se, but its a start (helps a bit with #16 )

If you want to try it out I suggest you mock a failed api call in merge_request.js inside the merge action with

merge({ dispatch }, mr) {
    return Promise.reject(new Error('fake error'))
    // const gl = gitlab.get();
    //
    // return gl.client.merge(mr).then(() => {
    //   dispatch("removeMergeRequest", mr);
    //   // TODO: Stop watchers for this MR
    // });
  }

Don't hesitate to suggest changes or offer feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant