Fixed pypi scraping issue causing issue #598 #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@potating-potato @richaagarwal pinging for visibility |
| @@ -148,7 +148,7 @@ def build_plugin_metadata(plugin: str, version: str) -> Tuple[str, dict]: | |||
| cached_plugin = get_cache(f'cache/{plugin}/{version}.json') | |||
| if cached_plugin: | |||
| return plugin, cached_plugin | |||
| metadata = get_plugin_pypi_metadata(plugin, version) | |||
There was a problem hiding this comment.
This is minor, but is there a reason not to pass version = None here and not make any of the following changes? (It could be nice to support versions depending on what we decide for follow-up work, but it'd be easy to put back so it's definitely a minor design decision for now).
There was a problem hiding this comment.
Oh yeah, that would work too, and it's probably a better way to do this to minimize side effects.
|
Yeah it looks like the cache populates with version=None too, should be able to merge whenever |
richaagarwal
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
We were unable to update the napari-hub due to #598, which happened due to pypi deprecating the "releases" field when querying with a version, causing our code to fail.
Changes:
I prevented use of versions by setting version=None whenever
get_plugin_pypi_metadatagets called. This fixes issue #598 because not asking for a version will allow us to access past releases while still retaining the same information as if we ask for the latest version. This should work because we query for the latest version anyways when gathering metadata from pypi.Testing:
Changes were tested using unit tests and then tested in the dev environment to see if the plugins will populate, which they did.
