Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial support for whole-array reduction on NVIDIA GPUs #23689

Merged
merged 42 commits into from
Nov 6, 2023
Merged

Add initial support for whole-array reduction on NVIDIA GPUs #23689

merged 42 commits into from
Nov 6, 2023

Commits on Oct 16, 2023

  1. Snapshot 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    096fdba View commit details
    Browse the repository at this point in the history

  2. Get things to link in a hacky way 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    9020bf5 View commit details
    Browse the repository at this point in the history

  3. Get the initial example working 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    df97abb View commit details
    Browse the repository at this point in the history

  4. Cleanup 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    01bcf84 View commit details
    Browse the repository at this point in the history

  5. Drop additional makefile logic 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    38dc53f View commit details
    Browse the repository at this point in the history

  6. Finish implementing basic reductions 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    3417301 View commit details
    Browse the repository at this point in the history

  7. Add test 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    17118b3 View commit details
    Browse the repository at this point in the history

  8. Add minloc and maxloc reduces 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    b5e689b View commit details
    Browse the repository at this point in the history

  9. Refactor basic reduce runtime interface, too 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    f036931 View commit details
    Browse the repository at this point in the history

  10. Move the actual reduction functions to the GPU module 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    41e30a9 View commit details
    Browse the repository at this point in the history

  11. Simplify runtime macros 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    8d0e3e0 View commit details
    Browse the repository at this point in the history

  12. Start separating impl implementations 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    c56df6b View commit details
    Browse the repository at this point in the history

  13. Seperate runtime interface from the implementation interface 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    7aa3642 View commit details
    Browse the repository at this point in the history

  14. Runtime cleanup 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    cf1e526 View commit details
    Browse the repository at this point in the history

  15. Add a common header 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    1489028 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Blind implementation of reductions on AMD 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    60f921c View commit details
    Browse the repository at this point in the history

  2. Add a compilerError in the module code 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    ab9b475 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Test/limit usage on AMD 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    5ab3e5e View commit details
    Browse the repository at this point in the history

  2. Fix an issue, add perf test 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    0819e31 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Initial attempt to do multi-chunk reduction 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    3a78ab2 View commit details
    Browse the repository at this point in the history

  2. Add a new test and fix an issue exposed by it 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    19ad754 View commit details
    Browse the repository at this point in the history

  3. Add new test 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    06be1a8 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Expand test to minloc,maxloc. Fix a bug 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d012a9b View commit details
    Browse the repository at this point in the history

  2. Make the new functions work with cpu-as-device. Add skipifs 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    e85a00c View commit details
    Browse the repository at this point in the history

  3. Add the missing good file 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    186ad54 View commit details
    Browse the repository at this point in the history

  4. Remove a trailing whitespace 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    4b6953f View commit details
    Browse the repository at this point in the history

  5. Revert some of the AMD changes 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    aca38c4 View commit details
    Browse the repository at this point in the history

  6. Add the missing execopts 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    257a6ae View commit details
    Browse the repository at this point in the history

  7. Remove an include 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9c49498 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Relocate tests into a new noAmd directory 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    1627385 View commit details
    Browse the repository at this point in the history

  2. Add a user facing error message for unknown types and a test to lock … 

    …the behavior

Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    ab8a348 View commit details
    Browse the repository at this point in the history

  3. Add more fall-through otherwises 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    7725662 View commit details
    Browse the repository at this point in the history

  4. Start adding documentation 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    6da77ee View commit details
    Browse the repository at this point in the history

  5. Add one more fallthrough, unify error messages 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    889ef73 View commit details
    Browse the repository at this point in the history

  6. Free runtime memory that we were leaking before 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    377f97d View commit details
    Browse the repository at this point in the history

  7. A big refactor to reduce code duplication significantly 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    1675b9e View commit details
    Browse the repository at this point in the history

  8. Fix a bug for non-zero-based arrays, add test 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    dd10162 View commit details
    Browse the repository at this point in the history

  9. Remove trailing whitespaces 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    7f007b7 View commit details
    Browse the repository at this point in the history

  10. More clarifications in doc 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    727f443 View commit details
    Browse the repository at this point in the history

  11. Add a missing space 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    79ea359 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Add missing commas in AMD runtime 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    cc39ef7 View commit details
    Browse the repository at this point in the history

  2. Move skipif to the parent directory 

    Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
    @e-kayrakli
    e-kayrakli committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    00ee967 View commit details
    Browse the repository at this point in the history