Add interface for retrieving alerting config from charmed AlertManager #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
relaxdiego
force-pushed
the
add-alerting
branch
3 times, most recently
from
086920f
to
689f5db
Compare
exceptorr
suggested changes
May 29, 2020
There was a problem hiding this comment.
Hey @relaxdiego - great job! Just a few comments to discuss.
|
Thanks for the review @exceptorr! Will address them now. |
relaxdiego
force-pushed
the
add-alerting
branch
5 times, most recently
from
3a780f5
to
634d3a6
Compare
This commit allows the charm to retrieve a configuration string from the alertmanager charm. The configuration string is a JSON string that this charm converts to a dict that is then inserted to another dict that ultimately gets serialized into a YAML-formatted prometheus config file. While this charm is agnostic to the contents of the JSON string, in AlertManager's current iteration, it uses the `kube_sd_configs` method so that Prometheus can quickly detect changes in the number of AlertManager pods without waiting for any Juju events.
relaxdiego
changed the title
exceptorr
suggested changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the charm to retrieve a configuration string from the
alertmanager charm. The configuration string is a JSON string that this
charm converts to a dict that is then inserted to another dict that
ultimately gets serialized into a YAML-formatted prometheus config file.
While this charm is agnostic to the contents of the JSON string, in
AlertManager's current iteration, it uses the
kube_sd_configsmethodso that Prometheus can quickly detect changes in the number of
AlertManager pods without waiting for any Juju events.