Skip to content

Commit

Permalink
Merge pull request prometheus#1878 from prometheus/stn/image-url-for-…
Browse files Browse the repository at this point in the history
…slack-config

Add image_url to example of good config
  • Loading branch information
stuartnelson3 authored May 6, 2019
2 parents a8847c6 + 6a0be9e commit 3055acd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ func TestHideConfigSecrets(t *testing.T) {

// String method must not reveal authentication credentials.
s := c.String()
if strings.Count(s, "<secret>") != 14 || strings.Contains(s, "mysecret") {
if strings.Count(s, "<secret>") != 15 || strings.Contains(s, "mysecret") {
t.Fatal("config's String method reveals authentication credentials.")
}
}
Expand Down
4 changes: 4 additions & 0 deletions config/testdata/conf.good.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,3 +140,7 @@ receivers:
pushover_configs:
- token: mysecret
user_key: key
- name: slack-receiver
slack_configs:
- channel: '#my-channel'
image_url: 'http://some.img.com/img.png'

0 comments on commit 3055acd

Please sign in to comment.