Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add user profile avatar #9298

Merged
merged 11 commits into from
Apr 26, 2024
Merged

feat: Add user profile avatar #9298

merged 11 commits into from
Apr 26, 2024

Conversation

muhsin-k
Copy link
Member

CleanShot 2024-04-25 at 17 05 57@2x

Copy link

linear bot commented Apr 25, 2024

CW-3221 Avatar component

@muhsin-k muhsin-k marked this pull request as ready for review April 26, 2024 04:35
Copy link
Member

@iamsivin iamsivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muhsin-k Added some review comments. Could you please take a look?

app/javascript/v3/components/Form/InitialsAvatar.vue Outdated Show resolved Hide resolved
app/javascript/v3/components/Form/ProfileAvatar.vue Outdated Show resolved Hide resolved
app/javascript/v3/components/Form/ProfileAvatar.vue Outdated Show resolved Hide resolved
app/javascript/v3/helpers/CommonHelper.js Show resolved Hide resolved
app/javascript/v3/components/Form/ProfileAvatar.vue Outdated Show resolved Hide resolved
Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com>
@muhsin-k
Copy link
Member Author

@iamsivin All the review comments are address. Please take a look.

@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9298 April 26, 2024 10:12 Inactive
@muhsin-k muhsin-k merged commit d88d0bd into develop Apr 26, 2024
12 of 13 checks passed
@muhsin-k muhsin-k deleted the feature/cw-3221 branch April 26, 2024 10:32
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants