Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https when possible. #1597

Merged
merged 2 commits into from
Dec 27, 2020
Merged

Use https when possible. #1597

merged 2 commits into from
Dec 27, 2020

Conversation

XhmikosR
Copy link
Contributor

There are only a few http links left in tests but those shouldn't matter a lot.

Should fix the mixed content issues on https://cheerio.js.org/

</a>
<a href="https://coveralls.io/r/cheeriojs/cheerio">
<img src="http://img.shields.io/coveralls/cheeriojs/cheerio.svg?branch=master&style=flat" alt="Coverage" />
<img src="https://img.shields.io/coveralls/cheeriojs/cheerio.svg?branch=main&style=flat" alt="Coverage" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coveralls doesn't seem to be integrated anymore. Should I drop the badge? Alternatively, we could bring coveralls back in #1600 later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to reset coveralls recently. I hope this will populate again soon.

@fb55 fb55 merged commit c6679ae into cheeriojs:main Dec 27, 2020
@fb55
Copy link
Member

fb55 commented Dec 27, 2020

Great idea, thanks a lot!

@XhmikosR XhmikosR deleted the https branch December 27, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants