Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update ruby version in a2a components #6142

Merged
merged 5 commits into from
Nov 17, 2021
Merged

Conversation

meet58
Copy link
Contributor

@meet58 meet58 commented Nov 16, 2021

Signed-off-by: meet58 mgadhiya@msystechnologies.com

🔩 Description: What code changed, and why?

Update ruby version

⛓️ Related Resources

👍 Definition of Done

I have updated ruby version in a2ha components

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: meet58 <mgadhiya@msystechnologies.com>
@netlify
Copy link

netlify bot commented Nov 16, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 233533b

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6194d60ce76fc50008c4904d

Signed-off-by: meet58 <mgadhiya@msystechnologies.com>
Signed-off-by: meet58 <mgadhiya@msystechnologies.com>
@meet58 meet58 mentioned this pull request Nov 17, 2021
Signed-off-by: meet58 <mgadhiya@msystechnologies.com>
Signed-off-by: meet58 <mgadhiya@msystechnologies.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@punitmundra punitmundra merged commit 99c0f91 into main Nov 17, 2021
@punitmundra punitmundra deleted the meet58/a2ha-ruby-upgrade branch November 17, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants