Make extraction safer #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thommay
commented
Jul 5, 2016
•
thommay
commented
- optionally ignore file permissions in the archive
- optionally ignore certain paths in the archive
thommay
force-pushed
the
ignore_perms_and_files
branch
from
dfccbf4
to
ca4139b
Compare
* Ignore file permissions in the archive * Ignore certain paths in the archive Signed-off-by: Thom May <thom@may.lt>
thommay
force-pushed
the
ignore_perms_and_files
branch
from
ca4139b
to
fe2dff9
Compare
|
Dropping this here as related: would it worth managing owner and group too (in name/numeric fashion as can do |
|
I'd certainly be open to taking a PR for that should someone need it - say for doing a tar resource or similar. |
|
👍 yeah i wondered about owner/group, but i haven't seen the use case for it yet |
|
@lamont-granquist I can't see one out of restoring a backup (which shouldn't be done in ruby IMHO), and so I'm really unsure the feature worth the extra complexity. I did asked as it sounded obvious to talk about it after this change, but I don't think this library should be a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.