mixlib-archive-tar create corrupt archives on Windows #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kenmacleod -- thank you so much for the contribution! When you have a moment can you please add a DCO sign off to your commits? Thanks! |
Signed-off-by: Ken MacLeod <ken.macleod@csgi.com>
Signed-off-by: Ken MacLeod <ken.macleod@csgi.com>
|
@kenmacleod Thanks for digging in on this one and finding the issue. This will be really helpful as we use this library in more places within Chef. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mixlib::Archive::Tar.create does not use
binmodeon Windows, corrupting binary files and probably not expected on mixed-line-end files.Issues Resolved
New issue chef/chef-dk#1913
Check List