Chefstyle fixes + test on Windows in Buildkite

.expeditor/verify.pipeline.yml

@@ -1,3 +1,9 @@
+---
+expeditor:
+  defaults:
+    buildkite:
+      timeout_in_minutes: 30
+
 steps:
 
 - label: run-lint-and-specs-ruby-2.4
@@ -32,3 +38,12 @@ steps:
     executor:
       docker:
         image: ruby:2.6-stretch
+
+- label: run-specs-windows
+  command:
+    - bundle install --jobs=7 --retry=3 --without docs debug
+    - bundle exec rake
+  expeditor:
+    executor:
+      docker:
+        host_os: windows

README.md

@@ -1,7 +1,7 @@
 # Mixlib::Archive
 
-[![Build status](https://badge.buildkite.com/96888f3b2f7a78af28fea0350cd3737011ab0f998627439e65.svg)](https://buildkite.com/chef-oss/chef-mixlib-archive-master-verify)
 [![Gem Version](https://badge.fury.io/rb/mixlib-archive.svg)](https://badge.fury.io/rb/mixlib-archive)
+[![Build status](https://badge.buildkite.com/96888f3b2f7a78af28fea0350cd3737011ab0f998627439e65.svg)](https://buildkite.com/chef-oss/chef-mixlib-archive-master-verify)
 
 **Umbrella Project**: [Chef Foundation](https://github.com/chef/chef-oss-practices/blob/master/projects/chef-foundation.md)
 
@@ -69,7 +69,7 @@ For information on contributing to this project please see our [Contributing Doc
 
 ## License & Copyright
 
-- Copyright:: Copyright (c) 2017-2018 Chef Software, Inc.
+- Copyright:: Copyright (c) 2017-2019 Chef Software, Inc.
 - License:: Apache License, Version 2.0
 
 ```text

Rakefile

@@ -40,4 +40,4 @@ task :console do
   IRB.start
 end
 
-task default: [:spec, :style]
+task default: %i{spec style}

lib/mixlib/archive.rb

@@ -58,6 +58,7 @@ def create_and_empty(destination)
       if @empty
         Dir.foreach(destination) do |entry|
           next if entry == "." || entry == ".."
+
           FileUtils.remove_entry_secure(File.join(destination, entry))
         end
       end

spec/mixlib/archive_spec.rb

@@ -61,22 +61,22 @@
     end
 
     it "runs the extractor" do
-      expect(archiver).to receive(:extract).with(destination, { perms: true, ignore: [/^\.$/, /\.{2}\//] })
+      expect(archiver).to receive(:extract).with(destination, { perms: true, ignore: [/^\.$/, %r{\.{2}/}] })
       archive.extract(destination)
     end
 
     it "passes options to the extractor" do
-      expect(archiver).to receive(:extract).with(destination, { perms: false, ignore: [/^\.$/, /\.{2}\//] })
+      expect(archiver).to receive(:extract).with(destination, { perms: false, ignore: [/^\.$/, %r{\.{2}/}] })
       archive.extract(destination, perms: false)
     end
 
     it "allows the user to ignore more patterns" do
-      expect(archiver).to receive(:extract).with(destination, { perms: false, ignore: [/^\.$/, /\.{2}\//, /^$/] })
+      expect(archiver).to receive(:extract).with(destination, { perms: false, ignore: [/^\.$/, %r{\.{2}/}, /^$/] })
       archive.extract(destination, perms: false, ignore: [/^$/])
     end
 
     it "accepts a single ignore pattern" do
-      expect(archiver).to receive(:extract).with(destination, { perms: false, ignore: [/^\.$/, /\.{2}\//, /^$/] })
+      expect(archiver).to receive(:extract).with(destination, { perms: false, ignore: [/^\.$/, %r{\.{2}/}, /^$/] })
       archive.extract(destination, perms: false, ignore: /^$/)
     end
   end