Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored demo and fixed flow check errors #435

Merged
merged 3 commits into from
Feb 28, 2017

Conversation

therewillbecode
Copy link
Contributor

Made demo variable names more descriptive

Copy link
Collaborator

@nkbt nkbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

mouse: [0, 0],
delta: [0, 0], // difference between mouse and circle pos, for dragging
mouseXY: [0, 0],
MouseCircleDelta: [0, 0], // difference between mouse and circle pos for x + y coords, for dragging
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon to keep style it need to start from small letter m

@chenglou
Copy link
Owner

Uncapitalized mouseCircleDelta. Thanks!

@chenglou chenglou merged commit 0f6637b into chenglou:master Feb 28, 2017
@therewillbecode therewillbecode deleted the demo-refactoring branch February 28, 2017 08:29
@therewillbecode
Copy link
Contributor Author

Thanks for the great library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants