Switch to format-specific sample rates #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the sample rate was a global option with choices that are known to work with every supported format. Most of these choices are not compatible with some upcoming formats, so switch to format-specific sample rates. As part of this change, selecting any valid sample rate supported by Android's encoders is now possible. Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
force-pushed
the
sample_rate
branch
from
78878b3
to
9383f17
Compare
chenxiaolong
added a commit
that referenced
this pull request
Feb 10, 2024
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the sample rate was a global option with choices that are known to work with every supported format. Most of these choices are not compatible with some upcoming formats, so switch to format-specific sample rates. As part of this change, selecting any valid sample rate supported by Android's encoders is now possible.