Automatically detect supported sample rates for each codec #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
chenxiaolong
force-pushed
the
detect-sample-rate
branch
2 times, most recently
from
3294415
to
05e55a8
Compare
Some devices unfortunately disable common sample rates that are normally supported in AOSP's software encoders. This commit reworks all of BCR's MediaCodec-based formats to query for the list of supported sample rates instead of relying on a hardcoded list. If BCR's default sample rate for a format is not supported, the closest supported sample rate will be used. The same applies for Android upgrades that remove support for the sample rate previously chosen by the user. These queries are fast enough to be unnoticeable on Pixel devices. Hopefully other OEMs don't make modifications that slow this down, like they do for so many other things. Fixes: #507 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
force-pushed
the
detect-sample-rate
branch
from
05e55a8
to
5f2b428
Compare
chenxiaolong
added a commit
that referenced
this pull request
Mar 3, 2024
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
quyenvsp
reviewed
May 3, 2024
| @@ -11,3 +12,14 @@ val AudioFormat.frameSizeInBytesCompat: Int | |||
| assert(encoding == AudioFormat.ENCODING_PCM_16BIT) | |||
| 2 * channelCount | |||
| } | |||
|
|
|||
| // Static extension functions are currently not supported in Kotlin. Also, we install a sysconfig | |||
There was a problem hiding this comment.
Hi, what mean "we install a sysconfig"? This line seem lead to crash on my Pixel 5a API 34.
Caused by: java.lang.NoSuchFieldException: No field SAMPLE_RATE_HZ_MIN in class Landroid/media/AudioFormat; (declaration of 'android.media.AudioFormat' appears in /system/framework/framework.jar!classes2.dex)
There was a problem hiding this comment.
That's referring to the /system/etc/sysconfig/config-com.chiller3.bcr.xml file, which is included in BCR's Magisk module. That's supposed to allow BCR to access hidden/system APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices unfortunately disable common sample rates that are normally supported in AOSP's software encoders. This commit reworks all of BCR's MediaCodec-based formats to query for the list of supported sample rates instead of relying on a hardcoded list. If BCR's default sample rate for a format is not supported, the closest supported sample rate will be used. The same applies for Android upgrades that remove support for the sample rate previously chosen by the user.
These queries are fast enough to be unnoticeable on Pixel devices. Hopefully other OEMs don't make modifications that slow this down, like they do for so many other things.
Fixes: #507