-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
path can be empty string #110
Conversation
Please provide a description and test plan for this PR. |
@chimurai for example
If I want to replace the whole path into an empty string, then it would complain "No rewritten path found" |
@@ -119,7 +119,7 @@ function HttpProxyMiddleware(context, opts) { | |||
if (pathRewriter) { | |||
var path = pathRewriter(req.url, req); | |||
|
|||
if (path) { | |||
if (path !== false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the condition to:
if (typeof path === 'string') {
...
}
Testing for a |
Can it be merged now @chimurai |
Sorry for the late response. |
No description provided.