error logging ignores router target #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
|
@bender316 |
|
This just came up in a Stack Overflow question, shame it didn't get merged 😕 |
|
I'm not working with http-proxy-middleware anymore. Maybe I find some time to rebase it but this really could take some time. Maybe it gets merged sometime. |
|
That's fair enough @bender316 - I'd be happy to create a new PR for this if a maintainer (@lerit?) thinks it would get merged. |
This was referenced Apr 12, 2021
|
fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm using a router function to override the target. If an error occurs the old target is written to the log which can be really misleading.
I changed the logging so that it first gets the router target and then uses one of the available targets for output.