New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat code by PEP8 and remove unused variables #1

Merged

chiphuyen merged 3 commits into chiphuyen:master from everping:master

Oct 5, 2018

Contributor

everping commented Oct 3, 2018 •

edited

Loading

In this pull request:

Remove variable has_sota in function extract_line since it is not used
Reformat code by using PEP8 Guide.
Add a guide in case you get a SSL error in MacOS
Import urllib.error instead of urllib. To my mind, requests is a perfect alternative for urllib, but I did not apply it in the project

everping and others added 3 commits

October 3, 2018 15:43


          Reformat code by PEP8 and remove unused variables

8dd5827


          Add a guide in case you get a SSL error

ff10e98


          import urllib.error instead of urllib

49e60e6

chiphuyen merged commit ba69bab into chiphuyen:master

Owner

chiphuyen commented Oct 5, 2018

Thanks a lot for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment