Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and upload macOS binaries for releases #1345

Closed
wants to merge 1 commit into from

Conversation

tymcauley
Copy link

@tymcauley tymcauley commented Jun 6, 2022

I'm a GitHub-Actions novice, so I'm open to suggestions if this isn't the right way to solve this problem.

Closes #1344.

Status: Pending resolution to #1404.

@hzeller
Copy link
Collaborator

hzeller commented Jun 24, 2022

Thanks!
We also already have set up a homebrew repo, but it needs to have some triggering enabled so that we can automatically build a new release there:
https://github.com/chipsalliance/homebrew-verible

... however, we need some owner who can help automating things; would you like to have a look @tymcauley ?

@hzeller
Copy link
Collaborator

hzeller commented Jun 24, 2022

the CI now ran, but it had some trouble in running the MacOS build, can you have a look ?

@tymcauley tymcauley force-pushed the macos-release branch 2 times, most recently from c12f37f to 3899397 Compare August 4, 2022 23:12
@codecov-commenter
Copy link

Codecov Report

Merging #1345 (3899397) into master (99f3203) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1345   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files         340      340           
  Lines       23832    23832           
=======================================
  Hits        22141    22141           
  Misses       1691     1691           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hzeller
Copy link
Collaborator

hzeller commented Sep 16, 2022

The MacOS build is still failing BTW, there might be more refining needed.

@tymcauley
Copy link
Author

Sorry for the delay on this, this still needs some work to get it functional, hopefully I'll have time to work on it in the near future.

@tymcauley
Copy link
Author

Looks like the macOS build is failing now at the install step, most likely due to the issue raised here: #1404 (comment)

@HendrikMennen
Copy link

Any news on this? Would be awesome to have macos binaries

@tymcauley
Copy link
Author

Any news on this? Would be awesome to have macos binaries

I think this won't work until #1404 is resolved.

@hzeller
Copy link
Collaborator

hzeller commented Apr 21, 2023

Until someone with access to a Mac has solved #1404 and sent a pull request, note also that there is a brew package available:
https://github.com/chipsalliance/homebrew-verible

@hzeller
Copy link
Collaborator

hzeller commented May 5, 2023

If the :install is not working yet due to #1404, this could probably be circumvented by manually installing the binaries.

That is also how the homebrew formula avoids that problem:

https://github.com/chipsalliance/homebrew-verible/blob/46664b28ed8f0dfe2d709faf45691cf42d9628b6/Formula/verible.rb#L34-L43

@hzeller
Copy link
Collaborator

hzeller commented Jul 20, 2023

I've now manually installed the binaries and packaged up things.

@hzeller hzeller closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] CI not building release binaries for macOS
4 participants