Skip to content
This repository has been archived by the owner on May 12, 2024. It is now read-only.

entity-async-graphql does not build -- pattern Binary(_) not covered #80

Open
apps4uco opened this issue Jun 4, 2022 · 3 comments
Open
Labels
bug Something isn't working

Comments

@apps4uco
Copy link

apps4uco commented Jun 4, 2022

Hi looks like an interesting project but I couldnt get the crate to build.

Steps to reproduce

cargo new entity-async-graphql-bug
cd entity-async-graphql-bug/
cargo add entity-async-graphql
cargo build

Compile Error

Compiling entity-async-graphql v0.3.2
error[E0004]: non-exhaustive patterns: `Binary(_)` not covered
   --> /home/user/.cargo/registry/src/-ba5a813e27fafabc/entity-async-graphql-0.3.2/src/ent/value.rs:26:15
    |
26  |         match value {
    |               ^^^^^ pattern `Binary(_)` not covered
    |
   ::: /home/user/.cargo/registry/src/-ba5a813e27fafabc/async-graphql-value-2.11.3/src/lib.rs:136:5
    |
136 |     Binary(Bytes),
    |     ------ not covered
    |
    = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
    = note: the matched value is of type `async_graphql::Value`

@chipsenkbeil
Copy link
Owner

@apps4uco the async-graphql library was known for not fully respecting semver. Let me see how many changes are needed to update this. I also can see that the latest version of async-graphql is 4.0.1 whereas we're using 2.7.4. So there may be major breaking changes to this extension.

@chipsenkbeil chipsenkbeil added the bug Something isn't working label Jun 4, 2022
@chipsenkbeil
Copy link
Owner

Filed a new issue against async-graphql. It's got versions of dependencies that it cannot build against, so I'm hitting issues trying to upgrade right now: async-graphql/async-graphql#941

@huang12zheng
Copy link

https://github.com/chipsenkbeil/entity-rs/blob/e5c27976dd7e44fc8d287898dd0b78b38e6aef75/integrations/entity-async-graphql/src/ent/value.rs
I want to know how add AsyncGraphqlValue::Binary to GqlValue.

Is there any new information? :-)

huang12zheng pushed a commit to huang12zheng/entity-rs that referenced this issue Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants