Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider renaming icons/ directory, as it clashes with some apache default configs #74

Closed
knurd opened this issue Nov 5, 2020 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@knurd
Copy link

knurd commented Nov 5, 2020

I'm getting 404 for everything in the icons/ directory after uploading it to my shared webspace. Turns out there is a name clash, as a icons/ directory in the root has a special meaning in some apache default confits. See https://electrictoolbox.com/apache-icons-directory/ or https://www.hosteurope.de/faq/webhosting/hochladen-von-webinhalten-ftp/verzeichnisnamen-mit-besonderer-funktion/ (german, sorry) for details – or google for something like ' "icons" directory webserver 404 '.

Hence please consider renaming the static/icons/ to something else.

@chipzoller
Copy link
Owner

Best we can probably do here is provide the option to use a different name, but the default of icons is quite standard in the vast majority of cases. @onweru do we want to support this?

@chipzoller chipzoller added the waiting Awaiting feedback or input. label Nov 8, 2020
@onweru
Copy link
Collaborator

onweru commented Nov 9, 2020

@chipzoller

Best we can probably do here is provide the option to use a different name, but the default of icons is quite standard in the vast majority of cases. @onweru do we want to support this?

I attempted accomodating this by implementing the tip from https://electrictoolbox.com/apache-icons-directory/ (suggested by @knurd). It introduces a breaking change. At this point, I would suggest we keep this open for future consideration.

@knurd,

As a temporary measure, I would recommend editing finding where icons/ paths is used and modifying accordingly:
grep -w -r -o -n "icons" .

@chipzoller chipzoller removed the waiting Awaiting feedback or input. label Nov 9, 2020
@chipzoller chipzoller added the help wanted Extra attention is needed label Nov 10, 2020
onweru added a commit that referenced this issue Mar 29, 2021
@onweru
Copy link
Collaborator

onweru commented Mar 29, 2021

@knurd, here

# tell hugo where you store your icons e.g favicons. This is useful if you're using an apache server and there are conflicts >> see issue https://github.com/chipzoller/hugo-clarity/issues/74. If this is applicable to you, be sure to copy the contents of https://github.com/chipzoller/hugo-clarity/tree/master/static/icons to your preferred icons directory
iconsDir = "icons/" # without a leading forward slash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants