Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Line Endings Configuration for repository #200

Closed
gep13 opened this issue Dec 24, 2014 · 3 comments
Closed

Correct Line Endings Configuration for repository #200

gep13 opened this issue Dec 24, 2014 · 3 comments
Assignees
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone

Comments

@gep13
Copy link
Member

gep13 commented Dec 24, 2014

Looks like as a result of making changes to work with this:

chocolatey-community/chocolatey-packages#37

Changes in this repository are no longer showing up correctly as files are marked as being completely changed, as can be seen here:

60f58cd

@ferventcoder @TomOne @Redsandro can any of you make suggestions as to what I need to do here to correct this going forward? Do I simply need to add a gitattributes file to this repository with similar settings are the core team packages repository? Or do I need to do a one-time change to all files in repository? Or am I completely off the mark here, and something else is wrong? Thanks!

gep13 added a commit that referenced this issue Dec 24, 2014
Changed to match gitattrobutes file for core team packages repo
@gep13 gep13 added 2 - Working Improvement Issues that enhances existing functionality, or adds new features labels Dec 24, 2014
@gep13 gep13 added this to the 0.12 milestone Dec 24, 2014
@gep13 gep13 self-assigned this Dec 24, 2014
@TomOne
Copy link

TomOne commented Dec 27, 2014

I guess the culprit was that core.autocrlf was set to true, right?

Do I simply need to add a gitattributes file to this repository with similar settings are the core team packages repository?

Yes, that should do it. See a related SO question: https://stackoverflow.com/questions/9933004/best-way-to-disable-git-end-of-line-normalization-crlf-to-lf-across-all-clones.

I see that you’ve made this change already. Did it solve the problem?

@RichiCoder1
Copy link
Contributor

@gep13 Seconding Tom's last question

@gep13
Copy link
Member Author

gep13 commented Dec 31, 2014

@TomOne @RichiCoder1 yes, I believe that this is now corrected.

You can see in this commit:

0ba3c0d

That the correct diff is displayed.

@gep13 gep13 closed this as completed Feb 10, 2015
RichiCoder1 pushed a commit to RichiCoder1/ChocolateyGUI that referenced this issue Jun 29, 2015
Changed to match gitattrobutes file for core team packages repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Development

No branches or pull requests

3 participants