Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that icons maintain their aspect ratio #633

Closed
Schroedingers-Cat opened this issue Jan 4, 2019 · 2 comments · Fixed by #667
Closed

Ensure that icons maintain their aspect ratio #633

Schroedingers-Cat opened this issue Jan 4, 2019 · 2 comments · Fixed by #667
Assignees
@punker76
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.17.0

Comments

@Schroedingers-Cat
Copy link

Currently, icons are forced into a 1:1 ratio in the details section of a package. As most programs have an icon with a 1:1 ratio, that is fine.

Sometimes, a software doesn't have an icon (because that software runs inside a host software hence there is no icon available) so you use a screenshot of the software from the developer's site. What chocolatey GUI does is turning this image into this:
grafik

So the image is quite distorted. It would be a nice improvement if ChocolateyGUI could keep the aspect ratio like it is done on the webpage of the community server.
@punker76 punker76 self-assigned this Apr 26, 2019
@punker76 punker76 added the Improvement Issues that enhances existing functionality, or adds new features label Apr 26, 2019
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 26, 2019
@punker76
(chocolateyGH-633) Keep aspect ratio for Icons in Tile and Package view
db496ec 
Also make the download of the icons faster by using a memory stream instead a temporary file stream.
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 26, 2019
@punker76
(chocolateyGH-633) MagickImage: Use read settings for correct loading…
010dd82 
… of svg icon files.
@punker76 punker76 mentioned this issue Apr 26, 2019
Merged
punker76 added a commit to punker76/ChocolateyGUI that referenced this issue Apr 26, 2019
@punker76
(chocolateyGH-633) Fix another Codacy/PR Quality Review issues
02cb73e 
But the second '.ConfigureAwait(false)' hint is wrong! So we should ignore this.
gep13 added a commit that referenced this issue Apr 27, 2019
@gep13
Merge pull request #667 from punker76/fix/GH-633
1fd1c1c 
(GH-633) Keep aspect ratio for Icons in Tile and Package view
@gep13 gep13 added this to the 0.17.0 milestone Apr 27, 2019
@gep13
Copy link
Member

gep13 commented Apr 27, 2019

@Schroedingers-Cat thank you for raising this. This has been corrected, and it will be included in the next release of Chocolatey GUI.

@gep13 gep13 changed the title Icons: keep aspect ratio Ensure that icons maintain their aspect ratio Mar 26, 2020
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punker76 punker76

Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.17.0
Development

Successfully merging a pull request may close this issue.

(GH-633) Keep aspect ratio for Icons in Tile and Package view punker76/ChocolateyGUI
4 participants
@punker76 @gep13 @choco-bot @Schroedingers-Cat