Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Chocolatey.Lib 0.10.15 #670

Closed
gep13 opened this issue May 3, 2019 · 4 comments
Closed

Update to Chocolatey.Lib 0.10.15 #670

gep13 opened this issue May 3, 2019 · 4 comments
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.17.0

Comments

@gep13
Copy link
Member

gep13 commented May 3, 2019

When doing this, remove the NuGetEncryptionUtility which was introduced in #665 as this will no longer be required.
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label May 3, 2019
@gep13 gep13 added this to the 0.17.0 milestone May 3, 2019
@gep13 gep13 mentioned this issue May 3, 2019
Open
@gep13 gep13 changed the title Update to Chocolatey.Lib 0.10.14 [BLOCKED] Update to Chocolatey.Lib 0.10.14 May 6, 2019
@gep13
Copy link
Member Author

gep13 commented May 6, 2019 •
edited
Loading

Can't do this until Chocolatey 0.10.15 is released.

@gep13 gep13 added the Blocked - External The issue or pull request is not fixable without a change in a upstream/external library label May 7, 2019
@gep13 gep13 changed the title [BLOCKED] Update to Chocolatey.Lib 0.10.14 Update to Chocolatey.Lib 0.10.14 May 7, 2019
@felschr
Copy link

felschr commented Jun 7, 2019

Any updates on this?

@gep13
Copy link
Member Author

gep13 commented Jun 11, 2019

@felschr my intention is to get to this, and the last remaining item in the milestone this week, and to get 0.17.0 released. Please understand that this isn't a commitment to this happening, but rather, that is what I am hoping to achieve.

@gep13 gep13 changed the title Update to Chocolatey.Lib 0.10.14 Update to Chocolatey.Lib 0.10.15 Jun 11, 2019
gep13 added a commit that referenced this issue Jun 11, 2019
@gep13
(GH-670) Update to latest Chocolatey.Lib
57c2ae1 
Now that 0.10.15 is released, there is some code in Chocolatey GUI that
can be removed, since this is now available directly from the lib.
Rather than duplicate code, it is better to re-use what is there.
gep13 added a commit that referenced this issue Jun 11, 2019
@gep13
(GH-670) Replace duplicated code
498cac2 
The NugetEncryptionUtility class has now been made available in
Chocolatey.Lib and therefore no longer needs to be duplicated here.
gep13 added a commit that referenced this issue Jun 11, 2019
@gep13
(GH-670) Fix attribute definition
d78da20 
This attribute was copied from Chocolatey.Lib as it was a sealed class
that couldn't be inherited.  In the latest version of Chocolatey.Lib
this was changed, and now it can be inherited.  Rather than duplicate
code, let's use the base class.
gep13 added a commit that referenced this issue Jun 11, 2019
@gep13
Merge branch 'feature/GH-670' into develop
831b6c5 
* feature/GH-670:
  (GH-670) Fix attribute definition
  (GH-670) Replace duplicated code
  (GH-670) Update to latest Chocolatey.Lib
@gep13 gep13 closed this as completed Jun 11, 2019
@gep13 gep13 removed the Blocked - External The issue or pull request is not fixable without a change in a upstream/external library label Jun 11, 2019
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
3 participants
@gep13 @felschr @choco-bot