Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty icon doesn't appear on local source view #674

Closed
gep13 opened this issue May 6, 2019 · 1 comment
Closed

Empty icon doesn't appear on local source view #674

gep13 opened this issue May 6, 2019 · 1 comment
Labels
Bug Issues where something has happened which was not expected or intended
Milestone
0.17.0

Comments

@gep13
Copy link
Member

gep13 commented May 6, 2019

When the is no iconUrl defined (either null or empty) Chocolatey GUI is meant to show the following icon:

image

As a placeholder. This works correctly when showing on the remote sources view, however, not when viewing the local source. This is due to the way in which the IconUrl is surfaced between a local package and one that comes from an oData source.
@gep13 gep13 added the Bug Issues where something has happened which was not expected or intended label May 6, 2019
@gep13 gep13 added this to the 0.17.0 milestone May 6, 2019
gep13 added a commit that referenced this issue May 6, 2019
@gep13
(GH-674) Fix empty icon now showing
42dd8e0 
If the IconUrl is null or empty, show the empty icon, rather than only
if it is null.
@gep13 gep13 closed this as completed May 6, 2019
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
2 participants
@gep13 @choco-bot