Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide ability to "see" persisted arguments for installed package #770

Closed
gep13 opened this issue Apr 27, 2020 · 3 comments · Fixed by #834 or #908
Closed

Provide ability to "see" persisted arguments for installed package #770

gep13 opened this issue Apr 27, 2020 · 3 comments · Fixed by #834 or #908
Assignees
@AdmiringWorm @steviecoaster
Labels
5 - Released The issue has been resolved, and released to the public for consumption Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Milestone
0.20.0

Comments

@gep13
Copy link
Member

gep13 commented Apr 27, 2020

This is similar to this issue: #767 but would allow only viewing of the arguments that were used, and not in the context of doing an upgrade.
@gep13
Copy link
Member Author

gep13 commented Apr 27, 2020

Perhaps related to this issue: chocolatey/choco#1310

steviecoaster added a commit to steviecoaster/ChocolateyGUI that referenced this issue Mar 28, 2021
@steviecoaster
(chocolatey#770) Begins to scaffold a Package Arguments button
3503989 
* Adds PackageArgumentsService Interface
* Adds button to PackageViewModel
* Adds method for decrypting .arguments file
@gep13 gep13 added this to the 0.19.0 milestone Apr 9, 2021
gep13 pushed a commit to steviecoaster/ChocolateyGUI that referenced this issue Apr 13, 2021
@steviecoaster @gep13
(chocolatey#770) Begins to scaffold a Package Arguments button
ac0a2a9 
* Adds PackageArgumentsService Interface
* Adds button to PackageViewModel
* Adds method for decrypting .arguments file
gep13 added a commit to gep13/ChocolateyGUI that referenced this issue Apr 14, 2021
@gep13 @steviecoaster
(chocolatey#770) Add ability to view install arguments
1fafb45 
This allows the viewing of the contents of the .arguments file, which
is stored on a per package version, and contains the arguments that
were passed into the choco install command for that package.

This file is encrypted, and can't be viewed directly, but this allows
decryption of the contents for viewing.

Co-authored-by: steviecoaster <stephen@chocolatey.io>
@AdmiringWorm AdmiringWorm added the Feature Issues that introduce new functionality to the project, instead of updating existing functionality label Jan 12, 2022
@AdmiringWorm AdmiringWorm self-assigned this Jan 20, 2022
@AdmiringWorm AdmiringWorm linked a pull request Jan 20, 2022 that will close this issue
(#770) Provide ability to "see" saved installation parameters #834
Merged
AdmiringWorm pushed a commit to steviecoaster/ChocolateyGUI that referenced this issue Jan 20, 2022
@gep13 @steviecoaster @AdmiringWorm
(chocolatey#770) Add ability to view install arguments
ab5c396 
This allows the viewing of the contents of the .arguments file, which
is stored on a per package version, and contains the arguments that
were passed into the choco install command for that package.

This file is encrypted, and can't be viewed directly, but this allows
decryption of the contents for viewing.

Co-authored-by: steviecoaster <stephen@chocolatey.io>
AdmiringWorm pushed a commit to steviecoaster/ChocolateyGUI that referenced this issue Jan 20, 2022
@gep13 @steviecoaster @AdmiringWorm
(chocolatey#770) Add ability to view install arguments
e2c2756 
This allows the viewing of the contents of the .arguments file, which
is stored on a per package version, and contains the arguments that
were passed into the choco install command for that package.

This file is encrypted, and can't be viewed directly, but this allows
decryption of the contents for viewing.

Co-authored-by: steviecoaster <stephen@chocolatey.io>
AdmiringWorm added a commit to steviecoaster/ChocolateyGUI that referenced this issue Jan 20, 2022
@AdmiringWorm
(chocolatey#770) Update arguments service behavior
b6887a1 
This commit updates the behavior used when parsing package arguments
to use the same logic as Chocolatey itself when it is parsing persisted
upgrade arguments.
AdmiringWorm added a commit to steviecoaster/ChocolateyGUI that referenced this issue Jan 20, 2022
@AdmiringWorm
(chocolatey#770) Replace normal message box with MahApps Dialog
2fc1e77 
This commit removes the use of a normal Windows MessageBox
to instead use the Dialog service to show a message instead.

This flows better into how the styling is used in the rest of the application.
gep13 added a commit to steviecoaster/ChocolateyGUI that referenced this issue Jan 20, 2022
@gep13 @steviecoaster
(chocolatey#770) Add ability to view install arguments
8d2d2c2 
This allows the viewing of the contents of the .arguments file, which
is stored on a per package version, and contains the arguments that
were passed into the choco install command for that package.

This file is encrypted, and can't be viewed directly, but this allows
decryption of the contents for viewing.

Co-authored-by: steviecoaster <stephen@chocolatey.io>
gep13 pushed a commit to steviecoaster/ChocolateyGUI that referenced this issue Jan 20, 2022
@AdmiringWorm @gep13
(chocolatey#770) Update arguments service behavior
b5d6014 
This commit updates the behavior used when parsing package arguments
to use the same logic as Chocolatey itself when it is parsing persisted
upgrade arguments.
gep13 pushed a commit to steviecoaster/ChocolateyGUI that referenced this issue Jan 20, 2022
@AdmiringWorm @gep13
(chocolatey#770) Replace normal message box with MahApps Dialog
e53b4f9 
This commit removes the use of a normal Windows MessageBox
to instead use the Dialog service to show a message instead.

This flows better into how the styling is used in the rest of the application.
gep13 added a commit to steviecoaster/ChocolateyGUI that referenced this issue Jan 21, 2022
@gep13 @steviecoaster
(chocolatey#770) Add ability to view install arguments
ba1938c 
This allows the viewing of the contents of the .arguments file, which
is stored on a per package version, and contains the arguments that
were passed into the choco install command for that package.

This file is encrypted, and can't be viewed directly, but this allows
decryption of the contents for viewing.

Co-authored-by: steviecoaster <stephen@chocolatey.io>
gep13 pushed a commit to steviecoaster/ChocolateyGUI that referenced this issue Jan 21, 2022
@AdmiringWorm @gep13
(chocolatey#770) Update arguments service behavior
e0a4481 
This commit updates the behavior used when parsing package arguments
to use the same logic as Chocolatey itself when it is parsing persisted
upgrade arguments.
gep13 pushed a commit to steviecoaster/ChocolateyGUI that referenced this issue Jan 21, 2022
@AdmiringWorm @gep13
(chocolatey#770) Replace normal message box with MahApps Dialog
e7329bf 
This commit removes the use of a normal Windows MessageBox
to instead use the Dialog service to show a message instead.

This flows better into how the styling is used in the rest of the application.
gep13 added a commit that referenced this issue Jan 21, 2022
@gep13
Merge pull request #834 from steviecoaster/gh770
e704b2d 
(#770) Provide ability to "see" saved installation parameters
@AdmiringWorm AdmiringWorm added 4 - Done Code has been added to the repository, and has been reviewed by a team member 2 - Working A user or team member has started working on the issue and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Jan 21, 2022
@AdmiringWorm
Copy link
Member

Re-Opening as there is additional minor work needed to complete this issue.

@AdmiringWorm AdmiringWorm reopened this Jan 21, 2022
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jan 24, 2022
@AdmiringWorm
(chocolatey#770) Disable showing of sensitive arguments
0baa8f4 
This commit replaces the values in sensitive arguments to instead show
the translatable string `[REDACTED ARGUMENT]` to ensure that sensitive
arguments are not displayed to the user.

This relies on the ArgumentUtility helper to detect whether the sensitive
argument should be shown or not.
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jan 24, 2022
@AdmiringWorm
(chocolatey#770) Show additional message on no arguments
74e058c 
This commit updates the dialog for showing package arguments
to have a notice that no arguments was found for the package in
the same dialog as normal arguments would show up with.
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jan 24, 2022
@AdmiringWorm
(chocolatey#770) Hide button for displaying arguments
73623ed 
This commit updates the package view to hide the button for
displaying package arguments when it is not displayed.
@AdmiringWorm AdmiringWorm mentioned this issue Jan 24, 2022
Merged
9 tasks
@AdmiringWorm AdmiringWorm added 3 - Review Code has been added, and is available for review as a pull request and removed 2 - Working A user or team member has started working on the issue labels Jan 24, 2022
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jan 27, 2022
@AdmiringWorm
(chocolatey#770) Disable showing of sensitive arguments
9d30975 
This commit replaces the values in sensitive arguments to instead show
the translatable string `[REDACTED ARGUMENT]` to ensure that sensitive
arguments are not displayed to the user.

This relies on the ArgumentUtility helper to detect whether the sensitive
argument should be shown or not.
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jan 27, 2022
@AdmiringWorm
(chocolatey#770) Show additional message on no arguments
375fbce 
This commit updates the dialog for showing package arguments
to have a notice that no arguments was found for the package in
the same dialog as normal arguments would show up with.
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jan 27, 2022
@AdmiringWorm
(chocolatey#770) Hide button for displaying arguments
352a05b 
This commit updates the package view to hide the button for
displaying package arguments when it is not displayed.
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jan 27, 2022
@AdmiringWorm
(chocolatey#770) Disable showing of sensitive arguments
f7b63a2 
This commit replaces the values in sensitive arguments to instead show
the translatable string `[REDACTED ARGUMENT]` to ensure that sensitive
arguments are not displayed to the user.

This relies on the ArgumentUtility helper to detect whether the sensitive
argument should be shown or not.
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jan 27, 2022
@AdmiringWorm
(chocolatey#770) Show additional message on no arguments
448c8b1 
This commit updates the dialog for showing package arguments
to have a notice that no arguments was found for the package in
the same dialog as normal arguments would show up with.
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jan 27, 2022
@AdmiringWorm
(chocolatey#770) Hide button for displaying arguments
e601182 
This commit updates the package view to hide the button for
displaying package arguments when it is not displayed.
gep13 added a commit that referenced this issue Jan 27, 2022
@gep13
Merge pull request #908 from AdmiringWorm/770-Provide-ability-to-see-…
1a6da50 
…persisted-arguments-for-installed-package

(#770) Provide ability to see persisted arguments for installed package
@AdmiringWorm AdmiringWorm added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 3 - Review Code has been added, and is available for review as a pull request labels Jan 27, 2022
gep13 added a commit that referenced this issue Feb 10, 2022
@gep13
Merge branch 'release/0.20.0'
803556b 
* release/0.20.0: (76 commits)
  (#841) Add assembly to correct nuget folder
  (#533) Handle null culture
  (maint) Fix formatting
  (#533) Allowing setting language during install
  (#545) Remove NumberOfPackageVersionsForSelection
  (#911) Add missing disabling of install buttons
  (#545) Add missing tooltip on disabled install button
  (maint) Cleanup trailing spaces and xmlns statements
  (maint) Remove unused using statements
  (#545) Disable certain values when other features is toggled
  (#533) Set current culture for WPF elements
  (#533) Fix remote sources being reloaded on language change
  (#545) Mark dialog as being open when child window is opened/closed
  (#545) Make version editable on advanced install
  (#545) Add future support for log file argument
  (maint) Remove format support for install configuration description
  (#545) Add missing entry for cache location
  (maint) Add missing description of UseLanguage config
  (#770) Hide button for displaying arguments
  (#770) Show additional message on no arguments
  ...
@gep13
Copy link
Member Author

gep13 commented Feb 10, 2022

🎉 This issue has been resolved in version 0.20.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@corbob corbob added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

@steviecoaster steviecoaster

Labels
5 - Released The issue has been resolved, and released to the public for consumption Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Projects
None yet
Milestone
0.20.0
4 participants
@gep13 @AdmiringWorm @steviecoaster @corbob