Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmation dialog when removing a source #827

Closed
gep13 opened this issue Mar 18, 2021 · 3 comments
Closed

Add confirmation dialog when removing a source #827

gep13 opened this issue Mar 18, 2021 · 3 comments
Labels
5 - Released The issue has been resolved, and released to the public for consumption Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Milestone
0.20.0

Comments

@gep13
Copy link
Member

gep13 commented Mar 18, 2021 •
edited
Loading

This is a destructive operation that cannot be undone, so we should confirm with the user that they really want to perform this action.
@gep13 gep13 added the Feature Issues that introduce new functionality to the project, instead of updating existing functionality label Mar 18, 2021
@gep13 gep13 added this to the 0.19.0 milestone Mar 18, 2021
@gep13
Copy link
Member Author

gep13 commented Mar 18, 2021

Similar issues exist for other operations:

This was referenced Mar 18, 2021
Closed
Closed
gep13 added a commit that referenced this issue Apr 8, 2021
@gep13
(#827) Add a confirmation when removing source
45703b8 
Since this is a destructive operation for both Chocolatey and Chocolatey
GUI we should verify that this is actually what the user intended to do
before proceeding with the operation.
@gep13
Copy link
Member Author

gep13 commented Apr 8, 2021

This has been added, and looks like the following:

image

@gep13 gep13 closed this as completed Apr 8, 2021
@AdmiringWorm AdmiringWorm added the 4 - Done Code has been added to the repository, and has been reviewed by a team member label Jan 21, 2022
@gep13
Copy link
Member Author

gep13 commented Feb 10, 2022

🎉 This issue has been resolved in version 0.20.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@gep13 gep13 mentioned this issue Feb 16, 2022
Closed
@corbob corbob added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Released The issue has been resolved, and released to the public for consumption Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Projects
None yet
Milestone
0.20.0
Development

No branches or pull requests
3 participants
@gep13 @AdmiringWorm @corbob