Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI for Feature and Settings lists #612

Conversation

punker76
Copy link
Member

This PR improves a little bit the UI for GUi and Feature Settings lists.

Todos after this PR:

  • the GUI settings needs now also a title for the UI
  • the GUI descriptions should be also be updated

Before
image

After
image

 - This template has 2 extra content controls to hold/show the on and off labels.
 - This improves the usage of the ToggleSwitch together with Margin, cause the control itself has always the same width.
 - This can be removed after it will be changed in MahApps...
@punker76 punker76 added the :UI label Jul 11, 2018
@gep13 gep13 added Improvement Issues that enhances existing functionality, or adds new features and removed :UI labels Jul 11, 2018
@gep13 gep13 added this to the 0.17.0 milestone Jul 11, 2018
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 596491d into chocolatey:develop Jul 11, 2018
@gep13
Copy link
Member

gep13 commented Jul 11, 2018

@punker76 thank you very much for submitting this!

@punker76 punker76 deleted the feature/Settings_Title_Desc_ToggleSwitch_Tweaks branch July 11, 2018 14:18
@gep13
Copy link
Member

gep13 commented Jul 11, 2018

@punker76 I have taken a first stab at adding titles and descriptions:

image

These will require new translations to be provided.

@gep13 gep13 changed the title UI Tweak for GUI and Feature Settings lists Improve UI for Feature and Settings lists Mar 26, 2020
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants