(GH-769) Prevent automatic outdated package check #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By enabeling this feature ChocolateyGUI will prevent checking for outdated packages on start. An extra button is added to check or refresh outdated packages.
mkevenaar
force-pushed
the
feature/GH-769
branch
from
46de272
to
d58a9ff
Compare
|
Ready for review @gep13 @punker76 @AdmiringWorm @mwallner |
mkevenaar
changed the title
Worked on this during the stream, trying to decide the best way to implement things. Went backwards and forwards on a few topics, but think we are getting closer to final result.
…e invalidating the command stuff Force invalidating the command stuff. This helps us to prevent disabled buttons after executing this routine. But IMO it has something to do with Caliburn.
|
After my changes...
|
The Show only outdated packages will now only be enabled when it makes sense.
|
I have made a small change to the translation to match the feature better. I also prevented the "Show Only Packages with Updates" to be enabled when we haven't checked for outdated packages. |
|
@mkevenaar your changes have been merged, thanks for your contribution 👍 |
|
@punker76 thanks also for your help on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #769