Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all packages from a source to be installed #23

Closed
ferventcoder opened this issue Jan 18, 2015 · 2 comments · Fixed by #2541
Closed

Allow all packages from a source to be installed #23

ferventcoder opened this issue Jan 18, 2015 · 2 comments · Fixed by #2541
Assignees
@TheCakeIsNaOH
Labels
5 - Released ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added Improvement
Milestone
2.3.0

Comments

@ferventcoder
Copy link
Member

No description provided.

@ferventcoder ferventcoder modified the milestone: 0.9.10 Jan 21, 2015
@ferventcoder ferventcoder modified the milestones: 0.9.10, 0.9.10.1 Oct 3, 2015
@ferventcoder ferventcoder modified the milestones: 0.9.10.1, 0.9.10.2, 0.9.10.3, 0.9.10.4, 0.9.10.5 Jun 17, 2016
@ferventcoder ferventcoder modified the milestones: 0.10.1, 0.10.2 Aug 15, 2016
@ferventcoder ferventcoder modified the milestones: 0.10.2, 0.10.3 Sep 20, 2016
@pauby pauby added this to the 2.3.0 milestone Dec 19, 2023
@TheCakeIsNaOH TheCakeIsNaOH self-assigned this Jan 9, 2024
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 9, 2024
@TheCakeIsNaOH
(chocolatey#23) Rename function
f47af28 
This renames the set_package_names_if_all_is_specified function to
set_local_package_names_if_all_is_specified. This is to increase
clarity for when the all keyword is implemented, and a function will be
to be added that sets packages names from a remote source.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 9, 2024
@TheCakeIsNaOH
(chocolatey#23) Implement all keyword for install command
0861a57 
This adds the ability to install all packages from a source via the all
keyword. It runs a list against the current sources, and sets the
package names from that list of packages.

This functionality is only intended to be used with internal
repositories. Therefore a list of public repositories has been added,
and the current sources are checked against it to ensure only internal
sources are specified.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 9, 2024
@TheCakeIsNaOH
(chocolatey#23) Disable install all keyword for alternate sources
0a431fd 
This throws a not implemented exception if the all keyword is used with
non-nuget alternate sources. This is because the all keyword only has
handling built in for normal sources, and it is better to throw an
error than to have the source try to install a package called "all"
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 9, 2024
@TheCakeIsNaOH
(chocolatey#23) Add tests for install all keyword
c5217a2 
One test to ensure that if the source is CCR that the install fails.
One test to ensure that all packages are install from a local source.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Apr 23, 2024
@TheCakeIsNaOH @gep13
(chocolatey#23) Rename function
247fdf1 
This renames the set_package_names_if_all_is_specified function to
set_local_package_names_if_all_is_specified. This is to increase
clarity for when the all keyword is implemented, and a function will be
to be added that sets packages names from a remote source.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Apr 23, 2024
@TheCakeIsNaOH @gep13
(chocolatey#23) Implement all keyword for install command
48ede18 
This adds the ability to install all packages from a source via the all
keyword. It runs a list against the current sources, and sets the
package names from that list of packages.

This functionality is only intended to be used with internal
repositories. Therefore a list of public repositories has been added,
and the current sources are checked against it to ensure only internal
sources are specified.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Apr 23, 2024
@TheCakeIsNaOH @gep13
(chocolatey#23) Disable install all keyword for alternate sources
68843fa 
This throws a not implemented exception if the all keyword is used with
non-nuget alternate sources. This is because the all keyword only has
handling built in for normal sources, and it is better to throw an
error than to have the source try to install a package called "all"
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Apr 23, 2024
@TheCakeIsNaOH @gep13
(chocolatey#23) Add tests for install all keyword
5cbbdce 
One test to ensure that if the source is CCR that the install fails.
One test to ensure that all packages are install from a local source.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Apr 23, 2024
@TheCakeIsNaOH @gep13
(chocolatey#23) Rename function
9d99168 
This renames the SetPackageNamesIfAllSpecified function to
SetLocalPackageNamesIfAllSpecified. This is to increase clarity for when
the all keyword is implemented, and a function will be added that sets
packages names from a remote source.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Apr 23, 2024
@TheCakeIsNaOH @gep13
(chocolatey#23) Implement all keyword for install command
1c958dc 
This adds the ability to install all packages from a source via the all
keyword. It runs a list against the current sources, and sets the
package names from that list of packages.

This functionality is only intended to be used with internal
repositories. Therefore a list of public repositories has been added,
and the current sources are checked against it to ensure only internal
sources are specified.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Apr 23, 2024
@TheCakeIsNaOH @gep13
(chocolatey#23) Disable install all keyword for alternate sources
066f64d 
This throws a not implemented exception if the all keyword is used with
non-nuget alternate sources. This is because the all keyword only has
handling built in for normal sources, and it is better to throw an
error than to have the source try to install a package called "all"
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Apr 23, 2024
@TheCakeIsNaOH @gep13
(chocolatey#23) Add tests for install all keyword
7a2e6a7 
One test to ensure that if the source is CCR that the install fails.
One test to ensure that all packages are install from a local source.
gep13 added a commit that referenced this issue Apr 23, 2024
@gep13
Merge pull request #2541 from TheCakeIsNaOH/install-all
43d9da4 
(#23) Handle all keyword for install
@gep13 gep13 added 4 - Done and removed 3 - Review labels Apr 23, 2024
gep13 added a commit to gep13/choco that referenced this issue May 24, 2024
@gep13
(chocolatey#23) Add tests to handle install all
644ca3e 
This commit adds some Pester tests to ensure that any attempts to run
the choco install all command is correctly handled when targeting
an alternative source.  This is simply asserting that there is an
error exit code, and that the correct output is displayed.

Some of the new tests are specifically set to only run on Test-Kitchen,
as there is the potential for changes to happen on the host machine,
and we don't want to impact people.
corbob pushed a commit to gep13/choco that referenced this issue May 27, 2024
@gep13 @corbob
(chocolatey#23) Add tests to handle install all
11d7115 
This commit adds some Pester tests to ensure that any attempts to run
the choco install all command is correctly handled when targeting
an alternative source.  This is simply asserting that there is an
error exit code, and that the correct output is displayed.

Some of the new tests are specifically set to only run on Test-Kitchen,
as there is the potential for changes to happen on the host machine,
and we don't want to impact people.
gep13 added a commit to gep13/choco that referenced this issue May 28, 2024
@gep13
(chocolatey#23) Add tests to handle install all
704cd65 
This commit adds some Pester tests to ensure that any attempts to run
the choco install all command is correctly handled when targeting
an alternative source.  This is simply asserting that there is an
error exit code, and that the correct output is displayed.

Some of the new tests are specifically set to only run on Test-Kitchen,
as there is the potential for changes to happen on the host machine,
and we don't want to impact people.
@pauby pauby changed the title Handle 'all' keyword for install Allow all packages from a source to be installed May 28, 2024
gep13 added a commit to gep13/choco that referenced this issue May 30, 2024
@gep13
(chocolatey#23) Add tests to handle install all
9205c4d 
This commit adds some Pester tests to ensure that any attempts to run
the choco install all command is correctly handled when targeting
an alternative source.  This is simply asserting that there is an
error exit code, and that the correct output is displayed.

Some of the new tests are specifically set to only run on Test-Kitchen,
as there is the potential for changes to happen on the host machine,
and we don't want to impact people.
gep13 added a commit that referenced this issue Jun 4, 2024
@gep13
(#23) Move call to SetRemotePackageNamesIfAllSpecified
80f86d5 
The SetRemotePackageNamesIfAllSpecified method HAS to be called AFTER
the call to GetRemoteRepositories.

In that method, the Sources on the configuration object are expanded to
be the full source URL's, rather than the named sources from the
chocolatey.config file, i.e. https://community.chocolatey.org/api/v2/
rather than simply "chocolatey".

This is important, since the full URL is what is used to ensure that a
"choco install all" is not being attempted against one of the
configured public sources.

This wasn't picked up during the initial PR review, but it was picked
up during manual testing, and this commit is the output of that manual
testing.
gep13 added a commit that referenced this issue Jun 5, 2024
@gep13
Merge branch 'release/2.3.0'
5dc8330 
* release/2.3.0: (153 commits)
  (#23) Move call to SetRemotePackageNamesIfAllSpecified
  (#1901) Revert commit to display location
  (maint) Update Authenticode Signature
  (tests) Some minor tweaks for test consistency
  (#310) Set-EnvironmentVariable: delete values properly
  (tests) Remove v2 import tests
  (#310) Fix test issues
  (#310) Fixup v2 compatibility
  (tests) Working on tests during pairing session
  (#2050) Add Pester test for --ignore-pinned option
  (#3381) Add Pester tests for rule command
  (#1144) Add Pester test to cover hash validation
  (#72) Add Pester tests to cover new functionality
  (test) Update assertions for push commands
  (#1310) Add Pester test to validate output
  (#23) Add tests to handle install all
  (#2200) Add test for new enhanced exit code
  (#1764) Add test for new enhanced exit code
  (#1760) Add test for new enhanced exit code
  (#1759) Add test for new enhanced exit code
  ...
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

gep13 added a commit that referenced this issue Jun 5, 2024
@gep13
Merge branch 'master' into develop
484999b 
* master: (37 commits)
  (#310) Fix path to chocolatey.lib files
  (maint) Corrected casing of file
  (#23) Move call to SetRemotePackageNamesIfAllSpecified
  (#1901) Revert commit to display location
  (maint) Update Authenticode Signature
  (tests) Some minor tweaks for test consistency
  (#310) Set-EnvironmentVariable: delete values properly
  (tests) Remove v2 import tests
  (#310) Fix test issues
  (#310) Fixup v2 compatibility
  (tests) Working on tests during pairing session
  (#2050) Add Pester test for --ignore-pinned option
  (#3381) Add Pester tests for rule command
  (#1144) Add Pester test to cover hash validation
  (#72) Add Pester tests to cover new functionality
  (test) Update assertions for push commands
  (#1310) Add Pester test to validate output
  (#23) Add tests to handle install all
  (#2200) Add test for new enhanced exit code
  (#1764) Add test for new enhanced exit code
  ...
josh-cooley added a commit to josh-cooley/choco that referenced this issue Jul 8, 2024
@josh-cooley
Merge branch 'develop' of https://github.com/josh-cooley/choco into d…
5e1e5cb 
…evelop

* 'develop' of https://github.com/josh-cooley/choco: (145 commits)
  (maint) Add CODEOWNERS files
  (build) Add templated notifications to all builds
  (build) Add verification of source scripts
  (doc) Further tweak docgen for Chocolatey.PowerShell
  (doc) Tweak docgen for Chocolatey.PowerShell
  (chocolatey#3446) Update GenerateDocs.ps1
  (chocolatey#3307) Do not create Tools directory from MSI
  (maint) Do not create Chocolatey directory in MSI
  (chocolatey#310) Fix path to chocolatey.lib files
  (maint) Corrected casing of file
  (chocolatey#23) Move call to SetRemotePackageNamesIfAllSpecified
  (chocolatey#1901) Revert commit to display location
  (maint) Update Authenticode Signature
  (tests) Some minor tweaks for test consistency
  (chocolatey#310) Set-EnvironmentVariable: delete values properly
  (tests) Remove v2 import tests
  (chocolatey#310) Fix test issues
  (chocolatey#310) Fixup v2 compatibility
  (tests) Working on tests during pairing session
  (chocolatey#2050) Add Pester test for --ignore-pinned option
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheCakeIsNaOH TheCakeIsNaOH

Labels
5 - Released ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added Improvement
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

(#23) Handle all keyword for install TheCakeIsNaOH/choco
5 participants
@ferventcoder @gep13 @choco-bot @pauby @TheCakeIsNaOH