Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort list of installed/upgraded packages #3112

Closed
2 tasks done
Bananeweizen opened this issue Apr 12, 2023 · 5 comments · Fixed by #3142
Closed
2 tasks done

Sort list of installed/upgraded packages #3112

Bananeweizen opened this issue Apr 12, 2023 · 5 comments · Fixed by #3142
Assignees
@AdmiringWorm
Labels
5 - Released Improvement Priority_LOW
Milestone
2.0.0

Comments

@Bananeweizen
Copy link

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

Consider the following screenshot:
grafik

How many applications have been upgraded? 6? No, 4 only, because of the foo and foo.install package duality.

Describe The Solution. Why is it needed?

Sorting the installed/upgraded packages would immediately group the foo and foo.install (as well as other "sibling") packages, making it way easier to get an overview of what changed from the users point of view.

Additional Context

No response

Related Issues

No response
@pauby
Copy link
Member

pauby commented Apr 14, 2023 •
edited
Loading

How many applications have been upgraded? 6? No, 4 only, because of the foo and foo.install package duality.

While it might be semantics, Chocolatey CLI does not list the upgraded applications. It lists the upgraded packages. In that context, foo and foo.install have been upgraded.

What command did you run?

@Bananeweizen
Copy link
Author

Bananeweizen commented Apr 14, 2023 •
edited
Loading

I've run choco upgrade all there. You are surely right about the semantics of packages (from the viewpoint of the chocolatey domain), but that is not what this issue is about. It's about mapping that output to the user's mental model. And my hypothesis is that the average user typically doesn't care that much about how the package structure (and dependencies) look like. She probably thinks more in terms of "applications installed with chocolatey", and then a sorted list might be easier to read and understand.

(And from a programmers point of view: I know that the applications have been upgraded in alphabetical order. Therefore I would expect a summary of these actions to reflect the same order. And a typical issue would be using a set for collecting the results, and the iteration order of that set not being identical to the insertion order, which is the case for most general-purpose set implementations.)

@pauby
Copy link
Member

pauby commented Apr 14, 2023

You are surely right about the semantics of packages (from the viewpoint of the chocolatey domain), but that is not what this issue is about.

You said this:

How many applications have been upgraded? 6? No, 4 only, because of the foo and foo.install package duality.

Which is what I responded to. Chocolatey doesn't manage applications. It manages packages. So, the output is correct as 6 packages were upgraded.

That's all I was clarifying for you.

Can the list of upgraded packages be sorted alphabetically? I'd imagine so.

@gep13
Copy link
Member

gep13 commented Apr 28, 2023

While working on issue #508, specifically, an issue with uninstalling of packages when they are failing dependency resolution, it helped to have the output from choco uninstall command ordered alphabetically, to aid with understanding which packages had been removed. In making this change, it also had the side-effect of fixing this request. In fact, the change had the effect of ordering the output for the install, upgrade, and uninstall command.

As such, I am going to move this issue into the 2.0.0 milestone, as it will be fixed in that release.

@gep13 gep13 added this to the 2.0.0 milestone Apr 28, 2023
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Apr 28, 2023
@AdmiringWorm
(chocolatey#3112) Sort summary results alphabetically
34298b7 
The summary outputted by Chocolatey CLI about installed,
upgrade or installed packages are listed in an unorder list of
package names.

This commit updates the report summary to ensure these are
reported in alphabetical order in each category.
@AdmiringWorm AdmiringWorm mentioned this issue Apr 28, 2023
Merged
10 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue May 2, 2023
@AdmiringWorm
(chocolatey#3112) Sort summary results alphabetically
800b4fb 
The summary outputted by Chocolatey CLI about installed,
upgrade or installed packages are listed in an unorder list of
package names.

This commit updates the report summary to ensure these are
reported in alphabetical order in each category.
@gep13 gep13 linked a pull request May 2, 2023 that will close this issue
(#508) Fix multiple packages being uninstall fails if one is a dependency #3142
Merged
10 tasks
@gep13 gep13 closed this as completed May 2, 2023
@gep13 gep13 added 4 - Done and removed 3 - Review labels May 2, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
5 - Released Improvement Priority_LOW
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(#508) Fix multiple packages being uninstall fails if one is a dependency AdmiringWorm/choco
5 participants
@Bananeweizen @gep13 @AdmiringWorm @choco-bot @pauby