Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2980) Remove webpi source runner #3068

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

vexx32
Copy link
Member

@vexx32 vexx32 commented Mar 15, 2023

Description Of Changes

  • Removed deprecation messages related to WebPI
  • Removed all references to WebPI and the source runner itself

Motivation and Context

This has been non functional for quite some time and is deprecated. Removing it for 2.0.

Testing

  1. Run choco with list -s webpi
  2. You should get a message about the source path not being resolved

Operating Systems Testing

Win11

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added / related tests have been removed
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #2980

@vexx32 vexx32 force-pushed the 2980-remove-webpi branch 2 times, most recently from 3154555 to e418616 Compare March 15, 2023 20:47
This has been non functional for quite some time and is deprecated.
Removing it for 2.0.

Updated end to end tests as well, and removed a reference to it in the
GenerateDocs.ps1 file.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit f167d17 into chocolatey:develop Mar 16, 2023
@gep13
Copy link
Member

gep13 commented Mar 16, 2023

@vexx32 thank you for getting this removed! 😄

@vexx32 vexx32 deleted the 2980-remove-webpi branch March 16, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove WebPI alternative source
2 participants