(maint) Add ability for Agent debugging #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
I took this for a spin as part of testing this PR: These changes make sense to me, and happy for them to go in. This will greatly improve our ability to debug the background service, especially when using Chocolatey GUI! |
Chocolatey Agent adds `--run-actual` on every Chocolatey CLI command run. When we're in debug mode and `--run-actual` is passed to Chocolatey CLI, we should not pause execution as the end as we're likely in agent and cannot acknowledge the pause. This also adds a change to the cake recipe to add `--run-actual` on the `unpackself` step as when we're building a debug version we don't want to pause for the user to press a key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Add the ability to debug Self Service Mode from Chocolatey Agent.
Motivation and Context
Chocolatey Agent adds
--run-actualon every Chocolatey CLI command run. When we're in debug mode and--run-actualis passed to Chocolatey CLI, we should not pause execution at the end as we're likely in agent and cannot acknowledge the pause.This also adds a change to the cake recipe to add
--run-actualon theunpackselfstep as when we're building a debug version we don't want to pause for the user to press a key.Testing
./build.debug.batand confirmed it didn't wait for me to press any key.--run-actualand configmred it didn't wait for me to press any key.Operating Systems Testing
Windows 10
Change Types Made
Change Checklist
Related Issue