Skip to content

Commit

Permalink
monitor: Use qemu_get_cpu() in monitor_set_cpu()
Browse files Browse the repository at this point in the history
No functional change, just a reduction of CPU loops.

The mon_cpu field is left untouched for now since changing that requires
a number of larger prerequisites, including cpu_synchronize_state() and
mon_get_cpu().

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
  • Loading branch information
afaerber committed Mar 12, 2013
1 parent d76fdda commit 1c8bb3c
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions monitor.c
Original file line number Diff line number Diff line change
Expand Up @@ -855,17 +855,14 @@ EventInfoList *qmp_query_events(Error **errp)
/* set the current CPU defined by the user */
int monitor_set_cpu(int cpu_index)
{
CPUArchState *env;
CPUState *cpu;

for (env = first_cpu; env != NULL; env = env->next_cpu) {
cpu = ENV_GET_CPU(env);
if (cpu->cpu_index == cpu_index) {
cur_mon->mon_cpu = env;
return 0;
}
cpu = qemu_get_cpu(cpu_index);
if (cpu == NULL) {
return -1;
}
return -1;
cur_mon->mon_cpu = cpu->env_ptr;
return 0;
}

static CPUArchState *mon_get_cpu(void)
Expand Down

0 comments on commit 1c8bb3c

Please sign in to comment.