Skip to content

Commit

Permalink
aio / timers: Add QEMUTimerListGroup to AioContext
Browse files Browse the repository at this point in the history
Add a QEMUTimerListGroup each AioContext (meaning a QEMUTimerList
associated with each clock is added) and delete it when the
AioContext is freed.

Signed-off-by: Alex Bligh <alex@alex.org.uk>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  • Loading branch information
abligh authored and stefanhaRH committed Aug 22, 2013
1 parent 754d6a5 commit dae21b9
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 0 deletions.
2 changes: 2 additions & 0 deletions async.c
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ aio_ctx_finalize(GSource *source)
event_notifier_cleanup(&ctx->notifier);
qemu_mutex_destroy(&ctx->bh_lock);
g_array_free(ctx->pollfds, TRUE);
timerlistgroup_deinit(&ctx->tlg);
}

static GSourceFuncs aio_source_funcs = {
Expand Down Expand Up @@ -244,6 +245,7 @@ AioContext *aio_context_new(void)
aio_set_event_notifier(ctx, &ctx->notifier,
(EventNotifierHandler *)
event_notifier_test_and_clear);
timerlistgroup_init(&ctx->tlg);

return ctx;
}
Expand Down
4 changes: 4 additions & 0 deletions include/block/aio.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include "qemu/queue.h"
#include "qemu/event_notifier.h"
#include "qemu/thread.h"
#include "qemu/timer.h"

typedef struct BlockDriverAIOCB BlockDriverAIOCB;
typedef void BlockDriverCompletionFunc(void *opaque, int ret);
Expand Down Expand Up @@ -73,6 +74,9 @@ struct AioContext {

/* Thread pool for performing work and receiving completion callbacks */
struct ThreadPool *thread_pool;

/* TimerLists for calling timers - one per clock type */
QEMUTimerListGroup tlg;
};

/**
Expand Down
3 changes: 3 additions & 0 deletions tests/test-aio.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

#include <glib.h>
#include "block/aio.h"
#include "qemu/timer.h"

AioContext *ctx;

Expand Down Expand Up @@ -630,6 +631,8 @@ int main(int argc, char **argv)
{
GSource *src;

init_clocks();

ctx = aio_context_new();
src = aio_get_g_source(ctx);
g_source_attach(src, NULL);
Expand Down
3 changes: 3 additions & 0 deletions tests/test-thread-pool.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include "block/aio.h"
#include "block/thread-pool.h"
#include "block/block.h"
#include "qemu/timer.h"

static AioContext *ctx;
static ThreadPool *pool;
Expand Down Expand Up @@ -205,6 +206,8 @@ int main(int argc, char **argv)
{
int ret;

init_clocks();

ctx = aio_context_new();
pool = aio_get_thread_pool(ctx);

Expand Down

0 comments on commit dae21b9

Please sign in to comment.