Skip to content

Commit

Permalink
[Filters] Fix operator overflowing out popover (elastic#50030)
Browse files Browse the repository at this point in the history
* Fixes combo overflow when the selected field is large

* Prettier quotes

* Changes the style class attribute to use Eui calculation and also the
class name to conform to the BEM naming convention

* Lints src/plugins/newsfeed/public/lib/api.test.ts
  • Loading branch information
ffknob authored and chrisronline committed Nov 14, 2019
1 parent ccd6e2e commit 16248f7
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
@import 'variables';
@import 'global_filter_group';
@import 'global_filter_item';
@import 'filter_editor/index';
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.globalFilterEditor__fieldInput {
max-width: $euiSize * 13;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
@import 'filter_editor';
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ class FilterEditorUI extends Component<Props, State> {
private renderFieldInput() {
const { selectedIndexPattern, selectedField } = this.state;
const fields = selectedIndexPattern ? getFilterableFields(selectedIndexPattern) : [];

return (
<EuiFormRow
label={this.props.intl.formatMessage({
Expand All @@ -266,6 +267,7 @@ class FilterEditorUI extends Component<Props, State> {
onChange={this.onFieldChange}
singleSelection={{ asPlainText: true }}
isClearable={false}
className="globalFilterEditor__fieldInput"
data-test-subj="filterFieldSuggestionList"
/>
</EuiFormRow>
Expand Down

0 comments on commit 16248f7

Please sign in to comment.