forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Accessibility] Give kuiTables keyboard-accessible column headers (el…
…astic#13586) * Make KuiTable headers keyboard-accessible in UI Framework. * Use flexbox to consistently apply spacing between table header cell text and sort icon. * Add aria-label attributes to KuiTableHeaderCell, KuiTableHeaderCheckBoxCell, and KuiTableRowCheckBoxCell. * Update Jest snapshots. * Update Dashboard listing table with new markup. * Update Saved Objects tables with new markup. * Update Settings table with new markup. * Update Visualize listing table with new markup. * Remove padding-right for cells containing checkboxes. * Update sortableColumn directive with new markup.
- Loading branch information
1 parent
2a6bd1b
commit 381a129
Showing
22 changed files
with
628 additions
and
599 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
<div ng-click="sortableColumn.toggle()"> | ||
<div | ||
class="kuiTableHeaderCell__liner" | ||
ng-transclude | ||
></div> | ||
<span | ||
class="kuiTableSortIcon kuiIcon fa-long-arrow-up" | ||
ng-show="sortableColumn.isSortedAscending()" | ||
></span> | ||
<span | ||
class="kuiTableSortIcon kuiIcon fa-long-arrow-down" | ||
ng-show="sortableColumn.isSortedDescending()" | ||
></span> | ||
</div> | ||
<button | ||
class="kuiTableHeaderCellButton" | ||
ng-class="{'kuiTableHeaderCellButton-isSorted': sortableColumn.isSorted()}" | ||
ng-click="sortableColumn.toggle()" | ||
aria-label="{{sortableColumn.getAriaLabel()}}" | ||
> | ||
<span class="kuiTableHeaderCell__liner"> | ||
<span ng-transclude></span> | ||
<span | ||
class="kuiTableSortIcon kuiIcon" | ||
ng-class="sortableColumn.isSortedAscending() ? 'fa-long-arrow-up' : 'fa-long-arrow-down'" | ||
></span> | ||
</span> | ||
</button> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.