Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update With Saved Object Client changes #4

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
106 commits
Select commit Hold shift + click to select a range
f87ef51
[ML] Fix start datafeed start time selection (#21203)
jgowdyelastic Jul 25, 2018
43d41f7
Add method to wait for loading to complete in Add Panel table (#21109)
Jul 25, 2018
b831ecf
Prune our usage of bootstrap (#21186)
snide Jul 25, 2018
8a6c531
fix: kuery autocomplete in apm (#21249)
lukasolson Jul 25, 2018
72b779c
[Test] Add Reporting in test on kibana_stats telemetry (#21118)
tsullivan Jul 25, 2018
58eefb8
Add bolilerplate sass for Kibana core (#21185)
snide Jul 26, 2018
124ec66
[ML] Fix saving of custom URLs for job created in Advanced page (#21207)
peteharverson Jul 26, 2018
38dcda0
Fix refreshed dashboard losing time range (#20858)
stacey-gammon Jul 26, 2018
a99140d
[ML] Clear bucket span invalid label (#21262)
jgowdyelastic Jul 26, 2018
a121550
[ML] Improved job validation messages. (#21191)
walterra Jul 26, 2018
c16a821
[ML] Fixes enabled state of detector rule scope options (#21263)
peteharverson Jul 26, 2018
0499205
rbac functional ui test (#21188)
rashmivkulkarni Jul 26, 2018
27e8500
Always use EMS production url, even in dev (#21237)
thomasneirynck Jul 26, 2018
99d1729
Add EMS hot link (#21154)
thomasneirynck Jul 26, 2018
d1f6f8f
[ML] Displaying edit job save failures in error bar (#21268)
jgowdyelastic Jul 26, 2018
5eabdd5
fix quote vs backtick typo (#21285)
Bargs Jul 26, 2018
489e5bb
[kbn-es] Only enable security for trial (#20803)
tylersmalley Jul 26, 2018
5fcd10e
Reenable import objects tests (#21250)
cjcenizal Jul 27, 2018
b328bd0
Verify that we've navigated to Settings by checking the title. (#21245)
cjcenizal Jul 27, 2018
60706bf
[ML] Better model memory limit validation (#21270)
jgowdyelastic Jul 27, 2018
0ef0369
[ML] Adds missing tooltips to custom URL editor buttons (#21279)
peteharverson Jul 27, 2018
2569542
[APM] Fix duplicate service calls (#21271)
sorenlouv Jul 27, 2018
3b6c9e3
[ML] Improves bucket span estimator stability. (#21282)
walterra Jul 27, 2018
6c46e3b
[ML] Updating invalid model memory limit message (#21329)
jgowdyelastic Jul 27, 2018
bd03506
Wait for visualizations to render in tests (#21258)
timroes Jul 27, 2018
15e3e59
Switching from jade to pug (#21047)
kobelb Jul 27, 2018
a4fca01
Updating macaddress (#21048)
kobelb Jul 27, 2018
0870fd8
Updating minimatch (#21050)
kobelb Jul 27, 2018
80a83f5
[APM] Kuery fixes (#21272)
sorenlouv Jul 27, 2018
9be216d
[ML] Fixing error bar position in advanced job page (#21336)
jgowdyelastic Jul 27, 2018
7a0c61f
relax threshold (#21305)
thomasneirynck Jul 27, 2018
ed40c34
[DOCS] Augments job validation tips (#21184)
lcawl Jul 27, 2018
e7b9c7d
better fix for flaky management settings test (#21171)
bmcconaghy Jul 27, 2018
1eaed69
fix: name in import resolver readme (#21316)
w33ble Jul 27, 2018
787c7a2
EUI@3.0.3 (#21363)
snide Jul 27, 2018
393150d
Allow TranspileScssTask to fail during a build (#21309)
tylersmalley Jul 27, 2018
be6a266
Re-enable Dashboard time changes functional test. (#21323)
cjcenizal Jul 27, 2018
30d4e70
[Monitoring] Remove node_resolver Setting (#21181)
pickypg Jul 27, 2018
0078e66
Retry the entire screenshotStitcher call (#20770)
stacey-gammon Jul 28, 2018
bed72f2
Add pluggable panel action tests (#20163)
stacey-gammon Jul 28, 2018
3e76039
maps wms settings refactoring (#20371)
ppisljar Jul 30, 2018
e28f2f3
fixing editor bug with apply being disabled in some cases (#21333)
ppisljar Jul 30, 2018
de7b09d
[ML] Fixing missing tooltips on results buttons (#21352)
jgowdyelastic Jul 30, 2018
00be773
Fix empty vis toasts (#21388)
timroes Jul 30, 2018
9fc4438
[ML] Fixing formatting of processed record count in jobs list (#21395)
jgowdyelastic Jul 30, 2018
37d12fa
Make `/api/security/v1/login` to return `204` status code if no paylo…
azasypkin Jul 30, 2018
588bf14
add mutation observer polyfill for jest test env (#20996)
nreese Jul 30, 2018
943681b
[ML] Fix for wizard card layout when cloning (#21403)
jgowdyelastic Jul 30, 2018
2e54dac
[ML] Updates URLs in job validation messages (#21361)
lcawl Jul 30, 2018
a76b5d7
[ML] Fixes to text used on the Filter List and Rule Editor pages (#21…
peteharverson Jul 30, 2018
ea2e3b0
Fix "Export Everything" to properly constrain types (#21402)
legrego Jul 30, 2018
3877217
[ML] Fixing initial loading pane in single metric wizard (#21410)
jgowdyelastic Jul 30, 2018
889b4ea
Fix #21355, visualization controls showing up in reports (#21362)
chrisdavies Jul 30, 2018
7063dbc
Localization "Index Patterns" tab (#20525)
maryia-lapata Jul 30, 2018
f014085
[kfetch/FetchError] only call Error.captureStackTrace if it exists (#…
Jul 30, 2018
8399f8b
EUIfy PanelOptionsMenuForm. (#21375)
cjcenizal Jul 30, 2018
3b74158
Move EuiComboBox functional test utility functions into own service (…
nreese Jul 30, 2018
1532c5e
Migrate ui/notify/fatal_error to new platform (#20752)
Jul 30, 2018
9846120
bump EUI to 3.2.1 (#21425)
nreese Jul 30, 2018
430ad15
Fix "export everything" (#21434)
legrego Jul 31, 2018
149ff8e
[ML] Fixing crash in fields service when user has no index permission…
jgowdyelastic Jul 31, 2018
1211efd
Upgrade prettier to version 1.14.0 (#21466)
weltenwort Jul 31, 2018
bacbf15
[Monitoring] Ensure we pass down the expiry_date for the license (#21…
chrisronline Jul 31, 2018
3dc1c2d
[Monitoring] Support legacy use cases for passthrough (#21211)
chrisronline Jul 31, 2018
0f7e355
[ML] Fixing lost dedicated index setting when cloning a job (#21472)
jgowdyelastic Jul 31, 2018
dfa1a43
Wait for saveSearch to reload, retry on openSavedSearch (#21371)
Jul 31, 2018
3dc5ba4
Fix formatting of 'Saved object not found' error toast. (#21421)
cjcenizal Jul 31, 2018
8d0b7e7
[junitReports] Rename reports so they are auto-discovered by CI (#21502)
Jul 31, 2018
8046ecf
Fix broken link to saved object from relationships flyout. (#21513)
cjcenizal Aug 1, 2018
9894ade
[APM] Update ruby onboarding instructions. (#21477)
simitt Aug 1, 2018
71e7262
fixing error with average bucket pipeline aggregation (#21400)
ppisljar Aug 1, 2018
27f2541
fixing embedded mode in visualize (#21468)
ppisljar Aug 1, 2018
295c5a9
Revert "Point issue links to new choose page (#19042)" (#21519)
timroes Aug 1, 2018
13598be
[APM] Fix column widths in EUI tables (#21490)
sorenlouv Aug 1, 2018
2ad265b
[APM] Document APM config settings (#21492)
sorenlouv Aug 1, 2018
aabe4f1
[ML] Support for the rare detector for charts in anomaly explorer and…
walterra Aug 1, 2018
ef559d3
Global time range in URL overwritten in certain situations. (#21440)
nreese Aug 1, 2018
8f9bf6a
add if check around using async handler object in VisEditorVisualizat…
nreese Aug 1, 2018
f256748
set pause to 'true' when refresh interval is zero (#21498)
nreese Aug 1, 2018
9cc95aa
fix: do not require kuery_autocomplete in APM (#21539)
lukasolson Aug 1, 2018
7f2a643
Skip flaky tests (#21439)
stacey-gammon Aug 1, 2018
d787b64
Add tests for default messages extraction tool (#21036)
LeanidShutau Aug 1, 2018
a66cb68
use SavedObjectsClientProvider to provide SavedObjectLoader with an a…
nreese Aug 1, 2018
93f9251
comment out flaky tests. (#21538)
stacey-gammon Aug 1, 2018
4bd7b74
Fix flaky context filters tests (#21511)
jen-huang Aug 1, 2018
1b9063b
Disable flaky Shard Allocation Per Index test. (#21577)
cjcenizal Aug 2, 2018
f43ffbc
Remove shouldComponentUpdate from MarkdownVisComponent, as it is caus…
chrisdavies Aug 2, 2018
9f3e36b
Set kibana locale in kibana.yml config (#21201)
Aug 2, 2018
a7f3cc9
accounting for angular delay in disabling input to fix test (#21530)
bmcconaghy Aug 2, 2018
e92240a
Show user feedback and block them from interacting with the UI while …
cjcenizal Aug 2, 2018
6aaddb9
Fix hidden ticks when using log scale (#21507)
markov00 Aug 2, 2018
7659cc2
[ML] Fixing jobs list refresh interval issue (#21593)
jgowdyelastic Aug 2, 2018
a0634c4
Range control - handle response when readonly user does not have inde…
nreese Aug 2, 2018
188d070
Fix bug in Discover no results screen caused by shard failure reason …
cjcenizal Aug 2, 2018
584c450
Pass a saved objects client to the collector fetch methods
tsullivan May 30, 2018
7a21e46
fix some tests
tsullivan Aug 2, 2018
1c8fcaf
fix another test
tsullivan Aug 2, 2018
8ee9559
summarize method for saved objects client
tsullivan Aug 2, 2018
9351ea6
First stab at providing a more generic way for collectors to format d…
chrisronline Jul 27, 2018
484be53
Rename and add a default case - there are some differences because of…
chrisronline Jul 31, 2018
1e3586d
Merge branch 'master' into monitoring/collector_format
tsullivan Aug 3, 2018
dbf1171
Merge commit '484be5347b' into monitoring/collector_format-usage-serv…
tsullivan Aug 3, 2018
83a0a0c
just remove combineStatsLegacy
tsullivan Aug 3, 2018
142558f
ability to make a new collection set based on a filter
tsullivan Aug 3, 2018
0e17392
formatForBulkUpload
tsullivan Aug 3, 2018
fd2d129
pick stuff apart a little
tsullivan Aug 3, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,4 @@ package-lock.json
.vscode
npm-debug.log*
.tern-project
index.css
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ _Note: The version numbers below are only examples, meant to illustrate the rela

## Questions? Problems? Suggestions?

- If you've found a bug or want to request a feature, please create a [GitHub Issue](https://github.com/elastic/kibana/issues/new/choose).
- If you've found a bug or want to request a feature, please create a [GitHub Issue](https://github.com/elastic/kibana/issues/new).
Please check to make sure someone else hasn't already created an issue for the same topic.
- Need help using Kibana? Ask away on our [Kibana Discuss Forum](https://discuss.elastic.co/c/kibana) and a fellow community member or
Elastic engineer will be glad to help you out.
5 changes: 2 additions & 3 deletions config/kibana.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,5 @@
# metrics. Minimum is 100ms. Defaults to 5000.
#ops.interval: 5000

# The default locale. This locale can be used in certain circumstances to substitute any missing
# translations.
#i18n.defaultLocale: "en"
# Specifies locale to be used for all localizable strings, dates and number formats.
#i18n.locale: "en"
16 changes: 12 additions & 4 deletions docs/migration/migrate_7_0.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
This section discusses the changes that you need to be aware of when migrating
your application to Kibana 7.0.

See also <<release-highlights>> and <<release-notes>>.
See also <<release-highlights>> and <<release-notes>>.

[float]
=== Removed support for tribe nodes
Expand All @@ -23,11 +23,11 @@ Kibana 7.0 will only use the Node.js distribution included in the package.
[float]
=== Advanced setting query:queryString:options no longer applies to filters
*Details:* In previous versions of Kibana the Advanced Setting `query:queryString:options` was applied to both queries
and custom filters using the `query_string` query. This could cause errors if a custom filter used options that
and custom filters using the `query_string` query. This could cause errors if a custom filter used options that
conflicted with the Advanced Setting. In 7.0 `query:queryString:options` will no longer be applied to filters so that
users can have full control over their custom filters.

*Impact:* You must ensure that any saved searches with a `query_string` filter aren't relying implicitly on
*Impact:* You must ensure that any saved searches with a `query_string` filter aren't relying implicitly on
`query:queryString:options`.

[float]
Expand All @@ -41,4 +41,12 @@ so we no longer need this workaround.
*Impact:* Since we'll no longer send the `default_field` parameter in Kibana's query_string query, Elasticsearch
will use the index setting instead. The default for the index setting is also `*`, so most users should not be impacted.
If some of your indices have a non-default `default_field` setting, you may want to update it or re-add the parameter
to Kibana's advanced setting.
to Kibana's advanced setting.

[float]
=== Deprecated kibana.yml setting `xpack.monitoring.node_resolver` has been removed
*Details:* This setting has been deprecated since 5.6, when it was explicitly recommended to use `uuid` as its value.

*Impact:* This setting is no longer necessary. If you enable {monitoring} across the Elastic Stack, a monitoring agent runs
on each Elasticsearch node, Logstash node, Kibana instance, and Beat to collect and index metrics. Each node and instance is
considered unique based on its persistent UUID, which is written to the path.data directory when the node or instance starts.
2 changes: 1 addition & 1 deletion docs/ml/creating-jobs.asciidoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[role="xpack"]
[[ml-jobs]]
== Creating Machine Learning Jobs
== Creating machine learning jobs

Machine learning jobs contain the configuration information and metadata
necessary to perform an analytics task.
Expand Down
87 changes: 74 additions & 13 deletions docs/ml/job-tips.asciidoc
Original file line number Diff line number Diff line change
@@ -1,24 +1,28 @@
[role="xpack"]
[[job-tips]]
=== Machine Learning Job Tips
=== Machine learning job tips
++++
<titleabbrev>Job Tips</titleabbrev>
<titleabbrev>Job tips</titleabbrev>
++++

When you are creating a job in {kib}, the job creation wizards can provide
advice based on the characteristics of your data. By heeding these suggestions,
you can create jobs that are more likely to produce insightful {ml} results.

[[bucket-span]]
==== Bucket Span
==== Bucket span

The bucket span is the time interval that {ml} analytics use to summarize and
model data for your job. When you create a job in {kib}, you can choose to
estimate a bucket span value based on your data characteristics. Typically, the
estimated value is between 5 minutes to 1 hour. If you choose a value that is
larger than one day or is significantly different than the estimated value, you
receive an informational message. For more information about choosing an
appropriate bucket span, see {xpack-ref}/ml-buckets.html[Buckets].
estimate a bucket span value based on your data characteristics.

NOTE: The bucket span must contain a valid time interval. For more information,
see {ref}/ml-job-resource.html#ml-analysisconfig[Analysis configuration objects].

If you choose a value that is larger than one day or is significantly different
than the estimated value, you receive an informational message. For more
information about choosing an appropriate bucket span, see
{xpack-ref}/ml-buckets.html[Buckets].

[[cardinality]]
==== Cardinality
Expand All @@ -30,16 +34,26 @@ detect when users are accessing resources differently than they usually do.

If the field that you use to split your data has many different values, the
job uses more memory resources. In particular, if the cardinality of the
`partition_field_name` is greater than 100, you are advised to consider
alternative options such as population analysis.
`by_field_name`, `over_field_name`, or `partition_field_name` is greater than
1000, you are advised that there might be high memory usage.

Likewise if you are performing population analysis and the cardinality of the
`over_field_name` is below 10, you are advised that this might not be a suitable
field to use.

For more information, see
field to use. For more information, see
{xpack-ref}/ml-configuring-pop.html[Performing Population Analysis].

[[detectors]]
==== Detectors

Each job must have one or more _detectors_. A detector applies an analytical
function to specific fields in your data. If your job does not contain a
detector or the detector does not contain a
{stack-ov}/ml-functions.html[valid function], you receive an error.

If a job contains duplicate detectors, you also receive an error. Detectors are
duplicates if they have the same `function`, `field_name`, `by_field_name`,
`over_field_name` and `partition_field_name`.

[[influencers]]
==== Influencers

Expand All @@ -60,3 +74,50 @@ do not need more than three. If you pick many influencers, the results can be
overwhelming and there is a small overhead to the analysis.

The job creation wizards in {kib} can suggest which fields to use as influencers.

[[model-memory-limits]]
==== Model memory limits

For each job, you can optionally specify a `model_memory_limit`, which is the
approximate maximum amount of memory resources that are required for analytical
processing. The default value is 1 GB. Once this limit is approached, data
pruning becomes more aggressive. Upon exceeding this limit, new entities are not
modeled.

You can also optionally specify the `xpack.ml.max_model_memory_limit` setting.
By default, it's not set, which means there is no upper bound on the acceptable
`model_memory_limit` values in your jobs.

TIP: If you set the `model_memory_limit` too high, it will be impossible to open
the job; jobs cannot be allocated to nodes that have insufficient memory to run
them.

If the estimated model memory limit for a job is greater than the model memory
limit for the job or the maximum model memory limit for the cluster, the job
creation wizards in {kib} generate a warning. If the estimated memory
requirement is only a little higher than the `model_memory_limit`, the job will
probably produce useful results. Otherwise, the actions you take to address
these warnings vary depending on the resources available in your cluster:

* If you are using the default value for the `model_memory_limit` and the {ml}
nodes in the cluster have lots of memory, the best course of action might be to
simply increase the job's `model_memory_limit`. Before doing this, however,
double-check that the chosen analysis makes sense. The default
`model_memory_limit` is relatively low to avoid accidentally creating a job that
uses a huge amount of memory.
* If the {ml} nodes in the cluster do not have sufficient memory to accommodate
a job of the estimated size, the only options are:
** Add bigger {ml} nodes to the cluster, or
** Accept that the job will hit its memory limit and will not necessarily find
all the anomalies it could otherwise find.

If you are using {ece} or the hosted Elasticsearch Service on Elastic Cloud,
`xpack.ml.max_model_memory_limit` is set to prevent you from creating jobs
that cannot be allocated to any {ml} nodes in the cluster. If you find that you
cannot increase `model_memory_limit` for your {ml} jobs, the solution is to
increase the size of the {ml} nodes in your cluster.

For more information about the `model_memory_limit` property and the
`xpack.ml.max_model_memory_limit` setting, see
{ref}/ml-job-resource.html#ml-analysisconfig[Analysis limits] and
{ref}/ml-settings.html[Machine learning settings].
13 changes: 13 additions & 0 deletions docs/settings/apm-settings.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,16 @@ You do not need to configure any settings to use APM. It is enabled by default.

xpack.apm.enabled:: Set to `false` to disabled the APM plugin {kib}. Defaults to
`true`.

xpack.apm.ui.enabled:: Set to `false` to hide the APM plugin {kib} from the menu. Defaults to
`true`.

apm_oss.indexPattern:: Index pattern is used for integrations with Machine Learning and Kuery Bar. It must match all apm indices. Defaults to `apm-&#42;`.

apm_oss.errorIndices:: Matcher for indices containing error documents. Defaults to `apm-&#42;-error-&#42;`.

apm_oss.onboardingIndices:: Matcher for indices containing onboarding documents. Defaults to `apm-&#42;-onboarding-&#42;`.

apm_oss.spanIndices:: Matcher for indices containing span documents. Defaults to `apm-&#42;-span-&#42;`.

apm_oss.transactionIndices:: Matcher for indices containing transaction documents. Defaults to `apm-&#42;-transaction-&#42;`.
17 changes: 9 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"url": "https://github.com/elastic/kibana.git"
},
"dependencies": {
"@elastic/eui": "3.0.0",
"@elastic/eui": "3.2.1",
"@elastic/filesaver": "1.1.2",
"@elastic/numeral": "2.3.2",
"@elastic/ui-ace": "0.2.3",
Expand Down Expand Up @@ -128,8 +128,8 @@
"fetch-mock": "^5.13.1",
"file-loader": "1.1.4",
"font-awesome": "4.4.0",
"glob": "5.0.13",
"glob-all": "3.0.1",
"glob": "^7.1.2",
"glob-all": "^3.1.0",
"good-squeeze": "2.1.0",
"h2o2": "5.1.1",
"h2o2-latest": "npm:h2o2@8.1.2",
Expand All @@ -140,8 +140,6 @@
"http-proxy-agent": "^2.1.0",
"https-proxy-agent": "^2.2.1",
"inert": "4.0.2",
"jade": "1.11.0",
"jade-loader": "0.8.0",
"joi": "10.4.1",
"jquery": "^3.3.1",
"js-yaml": "3.4.1",
Expand All @@ -158,7 +156,7 @@
"lodash": "3.10.1",
"lru-cache": "4.1.1",
"markdown-it": "^8.4.1",
"minimatch": "2.0.10",
"minimatch": "^3.0.4",
"mkdirp": "0.5.1",
"moment": "^2.20.1",
"moment-timezone": "^0.5.14",
Expand All @@ -170,6 +168,7 @@
"postcss-loader": "2.0.6",
"prop-types": "15.5.8",
"proxy-from-env": "1.0.0",
"pug": "^2.0.3",
"querystring-browser": "1.0.4",
"raw-loader": "0.5.1",
"react": "^16.3.0",
Expand Down Expand Up @@ -239,6 +238,7 @@
"@types/bluebird": "^3.1.1",
"@types/chance": "^1.0.0",
"@types/classnames": "^2.2.3",
"@types/enzyme": "^3.1.12",
"@types/eslint": "^4.16.2",
"@types/execa": "^0.9.0",
"@types/fetch-mock": "^5.12.2",
Expand Down Expand Up @@ -294,7 +294,7 @@
"getopts": "2.0.0",
"globby": "^8.0.1",
"grunt": "1.0.1",
"grunt-cli": "0.1.13",
"grunt-cli": "^1.2.0",
"grunt-contrib-watch": "^1.0.0",
"grunt-karma": "2.0.0",
"grunt-peg": "^2.0.1",
Expand Down Expand Up @@ -328,11 +328,12 @@
"mocha": "3.3.0",
"mock-fs": "^4.4.2",
"murmurhash3js": "3.0.1",
"mutation-observer": "^1.0.3",
"ncp": "2.0.0",
"nock": "8.0.0",
"node-sass": "^4.9.0",
"pixelmatch": "4.0.2",
"prettier": "^1.12.1",
"prettier": "^1.14.0",
"proxyquire": "1.7.11",
"simple-git": "1.37.0",
"sinon": "^5.0.7",
Expand Down
10 changes: 8 additions & 2 deletions packages/kbn-dev-utils/src/proc_runner/observe_readable.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,14 @@ import { first, ignoreElements, map } from 'rxjs/operators';
*/
export function observeReadable(readable) {
return Rx.race(
Rx.fromEvent(readable, 'end').pipe(first(), ignoreElements()),
Rx.fromEvent(readable, 'end').pipe(
first(),
ignoreElements()
),

Rx.fromEvent(readable, 'error').pipe(first(), map(err => Rx.throwError(err)))
Rx.fromEvent(readable, 'error').pipe(
first(),
map(err => Rx.throwError(err))
)
);
}
8 changes: 6 additions & 2 deletions packages/kbn-es/src/install/archive.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,14 @@ exports.installArchive = async function installArchive(archive, options = {}) {
await decompress(archive, installPath);
log.info('extracted to %s', chalk.bold(installPath));

if (license === 'trial') {
// starting in 6.3, security is disabled by default. Since we bootstrap
// the keystore, we can enable security ourselves.
await appendToConfig(installPath, 'xpack.security.enabled', 'true');
}

if (license !== 'oss') {
await appendToConfig(installPath, 'xpack.license.self_generated.type', license);

await appendToConfig(installPath, 'xpack.security.enabled', 'true');
await configureKeystore(installPath, password, log);
}

Expand Down
3 changes: 1 addition & 2 deletions packages/kbn-es/src/utils/decompress.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ const tarFs = require('tar-fs');

function decompressTarball(archive, dirPath) {
return new Promise((resolve, reject) => {
fs
.createReadStream(archive)
fs.createReadStream(archive)
.on('error', reject)
.pipe(zlib.createGunzip())
.on('error', reject)
Expand Down
2 changes: 1 addition & 1 deletion packages/kbn-eslint-import-resolver-kibana/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# @elastic/eslint-import-resolver-kibana
# @kbn/eslint-import-resolver-kibana

Resolver for Kibana imports, meant to be used with [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import).

Expand Down
30 changes: 13 additions & 17 deletions packages/kbn-i18n/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,25 +72,21 @@ export default function (kibana) {
}
```

The engine uses a locale resolution process similar to that of the built-in
Intl APIs to determine which locale data to use based on the `accept-language`
http header.

The following are the abstract steps i18n engine goes through to resolve the locale value:

- If there's data for the specified locale (localization file is registered in
`uiExports.translations`), then that locale will be resolved.
- If locale data is missing for a leaf locale like `fr-FR`, but there is data
for one of its ancestors, `fr` in this case, then its ancestor will be used.
- If `accept-language` header is not presented or previous steps didn't resolve
the locale, the locale will be resolved to locale defined in `i18n.defaultLocale`
option at `config/kibana.yml` file.

One of our technical requirements is to have default message in the templates
themselves, and that message will always be english, so we don't need interact
with `en.json` file directly. We can generate that file from `defaultMessage`s
The engine uses a `config/kibana.yml` file for locale resolution process. If locale is
defined via `i18n.locale` option in `config/kibana.yml` then it will be used as a base
locale, otherwise i18n engine will fall back to `en`. The `en` locale will also be used
if translation can't be found for the base non-English locale.

One of our technical requirements is to have default messages in the templates
themselves, and those messages will always be in English, so we don't have to keep
`en.json` file in repository. We can generate that file from `defaultMessage`s
defined inline.

__Note:__ locale defined in `i18n.locale` and the one used for translation files should
match exactly, e.g. `i18n.locale: zn` and `.../translations/zh_CN.json` won't match and
default English translations will be used, but `i18n.locale: zh_CN` and`.../translations/zh_CN.json`
or `i18n.locale: zn` and `.../translations/zn.json` will work as expected.

## I18n engine

I18n engine is the platform agnostic abstraction that helps to supply locale
Expand Down
1 change: 0 additions & 1 deletion packages/kbn-i18n/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"cross-env": "^5.2.0"
},
"dependencies": {
"accept-language-parser": "^1.5.0",
"intl-format-cache": "^2.1.0",
"intl-messageformat": "^2.2.0",
"intl-relativeformat": "^2.1.0",
Expand Down
Loading