ensure that click on typeahead options doesn’t change the url hash

christopherscott · Mar 11, 2015 · c86c9e6 · c86c9e6
1 parent b834aed
commit c86c9e6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/typeahead/option.js b/src/typeahead/option.js
@@ -32,13 +32,13 @@ var TypeaheadOption = React.createClass({
   render: function() {
     var classes = {
       hover: this.props.hover
-    }
+    };
     classes[this.props.customClasses.listItem] = !!this.props.customClasses.listItem;
     var classList = React.addons.classSet(classes);
 
     return (
       <li className={classList} onClick={this._onClick}>
-        <a href="#" className={this._getClasses()} ref="anchor">
+        <a href="javascript: void 0;" className={this._getClasses()} ref="anchor">
           { this.props.children }
         </a>
       </li>

diff --git a/test/typeahead-test.js b/test/typeahead-test.js
@@ -41,6 +41,14 @@ describe('Typeahead Component', function() {
       }, this);
     });
 
+    it('does not change the url hash when clicking on options', function() {
+      var results = simulateTextInput(this.component, 'o');
+      var firstResult = results[0];
+      var anchor = TestUtils.findRenderedDOMComponentWithTag(firstResult, 'a');
+      var href = anchor.getDOMNode().getAttribute('href');
+      assert.notEqual(href, '#');
+    });
+
     describe('keyboard controls', function() {
       it('down arrow + return selects an option', function() {
         var results = simulateTextInput(this.component, 'o');